feat(#319): add optional change_type_order#323
feat(#319): add optional change_type_order#323Lee-W merged 5 commits intocommitizen-tools:masterfrom KyleKing:issues/319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 97.17% 97.20% +0.02%
==========================================
Files 35 35
Lines 991 1000 +9
==========================================
+ Hits 963 972 +9
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think this is all done. I cleaned up the commit history so that the first commit is just a refactor to move the commit tree to a global variable for use by my new tests. The diff on the second commit are the actual changes: e855269 I've tested the changes in my personal project and all seems to work well even with custom change types: KyleKing/calcipy@4a480a8 |
|
Hi KyleKing, awesome work here! Minor correction, this is a new feature, so I'd like to ask you to rebase your PR using |
|
@woile, thanks! Good point 🤦 I amended the commit message |
KyleKing
left a comment
There was a problem hiding this comment.
I restored the white space changes and I think I addressed all of the comments. Thanks for the feedback!
Description
Implements proposed feature in #319. The default change type order is
["BREAKING CHANGE", "feat", "fix", "refactor", "perf"](in descending order of importance) followed by any other change types in alphabetical order. In the configuration file, a user can override this setting to specify their own order and cover custom change types of interest.Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
The
CHANGELOGshould be ordered in the user-specified order rather than FIFOSteps to Test This Pull Request
Run the standard pytest suite and see the two new test cases
Additional context
Fixes #319
Example use: KyleKing/calcipy@4a480a8