Add optional EMQX MQ configuration setting before installation#11549
Closed
sim-san wants to merge 3 commits intocommunity-scripts:mainfrom
Closed
Add optional EMQX MQ configuration setting before installation#11549sim-san wants to merge 3 commits intocommunity-scripts:mainfrom
sim-san wants to merge 3 commits intocommunity-scripts:mainfrom
Conversation
Member
|
This will Always run before the Script Run, Update and Install. What make this Feature? Why Not Just an read -rp in Install? |
Member
|
As Mick already stated, this belongs in the emqx-install.sh file, and then just do a read for that, like we have in all other apps. |
Author
|
Ok, will do |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
In this PR, I am adding a pre-installation prompt that allows users to enable or disable EMQX MQ functionality before container creation. This addresses a configuration requirement documented in the upstream EMQX issue.
Key Changes
• Updated resource requirements: HDD 4 -> 6 GB
• Added emqx_mq_setting() function to prompt user for EMQX MQ configuration
• Export EMQX_MQ__ENABLE environment variable (true/false) based on user selection
🔗 Related Issue
Fixes emqx/emqx#16649
See: emqx/emqx#16649 (comment)
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.