Update clang format spec to c++17 standard#134
Merged
vgvassilev merged 1 commit intocompiler-research:mainfrom May 31, 2024
Merged
Update clang format spec to c++17 standard#134vgvassilev merged 1 commit intocompiler-research:mainfrom
vgvassilev merged 1 commit intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 17 17
Lines 602 602
Branches 59 59
=======================================
Hits 452 452
Misses 150 150 |
anutosh491
approved these changes
May 31, 2024
Collaborator
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
Hmm, this does make sense to me though I haven't looked into any of the previous clang format work/PRs before so let's wait for another approval.
Collaborator
Author
|
@vgvassilev can you take a look at this change? @anutosh491 would like someone with experience in clang format to review also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the C++ standard in cmake set to c++17 but in the clang format spec its set to c++14 for some reason. This PR just updates the spec to the correct one.