Update clang-tidy-review action to v0.20.1#188
Merged
anutosh491 merged 2 commits intocompiler-research:mainfrom Nov 29, 2024
Merged
Update clang-tidy-review action to v0.20.1#188anutosh491 merged 2 commits intocompiler-research:mainfrom
anutosh491 merged 2 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 19 19
Lines 974 974
Branches 93 93
=======================================
Hits 787 787
Misses 187 187 |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
Hey Matthew, the emscripten build is expected to fail. I shall fix that soon and rebase the PR on top of it ! |
Collaborator
Author
|
@anutosh491 can you merge the PR now and fix the emscripten build in a later PR? This PR is only to fix the broken clang-tidy workflow, which is known to work with this fix. Your PR couldn't be checked with clang tidy otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
The clang-tidy-review workflow is currently broken. This was fixed by upgrading to a newer version of the action in other repos.
Fixes # (issue)
Type of change
Please tick all options which are relevant.