Drop pin on nlohmann json#378
Conversation
|
You also need to make the nlohmann_json_abi changes ! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 81.78% 82.10% +0.31%
==========================================
Files 20 20
Lines 950 950
Branches 87 87
==========================================
+ Hits 777 780 +3
+ Misses 173 170 -3 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
@anutosh491 Thanks for the tip. Can you point me towards the PR where this was done in Emscripten forge, and I will make the changes needed here. To me it seems that this PR was opened up straight after xeus-cpps recipe in Emscripten forge was updated to 0.7.2 |
|
Check the latest recipes on conda-forge and emscripten-forge (and use a git blame if that helps. On phone right now so won't be able to find a link) This is not an emscripten env specific change for your information. |
210b338 to
8130444
Compare
|
Not sure why nlohmann_json-abi can be found when doing the build on the Github runners, but not the read the docs build. I will investigate later. |
8130444 to
5fa9d44
Compare
a000e18 to
f0b68ee
Compare
anutosh491
left a comment
There was a problem hiding this comment.
Okay I'm guessing this solves the build the docs thing. Let's merge it and then you can close my previous Pr I guess ?
Description
Please include a summary of changes, motivation and context for this PR.
I was looking through Emscripten forges recipe repo and noticed the pin on nlohmann json is being dropped, so this PR does the same for the main repo.
Fixes # (issue)
Type of change
Please tick all options which are relevant.