Merge xeus-clang-repl mini - new kernels#58
Merged
vgvassilev merged 2 commits intocompiler-research:mainfrom Apr 10, 2024
Merged
Merge xeus-clang-repl mini - new kernels#58vgvassilev merged 2 commits intocompiler-research:mainfrom
vgvassilev merged 2 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 15 15
Lines 643 643
=======================================
Hits 316 316
Misses 327 327 |
Collaborator
|
@alexander-penev What is the difference between the cpp 17 (xcpp) kernel and the C++17 (xcpp) kernel? They appear to be the same. |
Collaborator
Author
Yes, maybe we should remove "cpp 17 (xcpp)". |
alexander-penev
force-pushed
the
MergeXeusClangReplMiniNewKernels
branch
2 times, most recently
from
b08ac91 to
54aa830
Compare
JohanMabille
requested changes
Apr 4, 2024
Collaborator
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
Do we need to keep share/jupyter/kernels/kernel.json.in ?
JohanMabille
approved these changes
Apr 10, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.