Skip to content

Update recipe to 3.2.0#9

Merged
menshikh-iv merged 12 commits into
conda-forge:masterfrom
souravsingh:update-recipe
Dec 29, 2017
Merged

Update recipe to 3.2.0#9
menshikh-iv merged 12 commits into
conda-forge:masterfrom
souravsingh:update-recipe

Conversation

@souravsingh
Copy link
Copy Markdown
Contributor

No description provided.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@souravsingh
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@souravsingh
Copy link
Copy Markdown
Contributor Author

souravsingh commented Dec 28, 2017

@jakirkham I used all the suggestions mentioned here but the SSL issue isn't fixed. Is there something I am doing wrong?

Comment thread recipe/meta.yaml Outdated
- forge_test.sh
commands:
- time bash ./forge_test.sh # [not win]
- nosetests --exe -v gensim
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to move into the shell script to work.

@souravsingh
Copy link
Copy Markdown
Contributor Author

@menshikh-iv The PR supersedes #8. Would you like to take a look and see if any changes need to be made?

Copy link
Copy Markdown
Member

@menshikh-iv menshikh-iv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Appveyor, I see that tests aren't executed, why @souravsingh?

Comment thread recipe/meta.yaml
- scikit-learn
- pyemd
- mock
- boto3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boto3 isn't gensim dependency

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the import tests throw an error due to boto3 dependency for smart_open. That's why I added it.

Comment thread appveyor.yml
# Add path, activate `conda` and update conda.
- cmd: call %CONDA_INSTALL_LOCN%\Scripts\activate.bat
- cmd: conda update --yes --quiet conda
- cmd: conda.exe update --yes --quiet conda
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only question - what's a reason for it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is made by the conda-forge admin. It is just for updating the testing for Windows platform and to update to latest version of Conda for testing.

Comment thread recipe/forge_test.sh
@@ -0,0 +1,10 @@
#! /bin/bash
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you "hide" testing in this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script contains environment variables for SSL_CERT_FILE and REQUESTS_CA_BUNDLE, without unsetting them beforehand, the downloader tests fail. So I used the solution used by people here for running the test suite for Linux.

@menshikh-iv menshikh-iv mentioned this pull request Dec 29, 2017
@souravsingh
Copy link
Copy Markdown
Contributor Author

Regarding Appveyor tests, The CI just runs the import tests. The latest commit should fix it.

@menshikh-iv
Copy link
Copy Markdown
Member

Thanks @souravsingh 👍

@menshikh-iv menshikh-iv merged commit 2f18b2f into conda-forge:master Dec 29, 2017
@souravsingh souravsingh deleted the update-recipe branch December 29, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants