Skip to content

Preserve inner exceptions in RestService#2571

Merged
Robert Yokota (rayokota) merged 3 commits into
confluentinc:masterfrom
yykkibbb:fix/preserve-inner-exception-in-rest-service
Feb 20, 2026
Merged

Preserve inner exceptions in RestService#2571
Robert Yokota (rayokota) merged 3 commits into
confluentinc:masterfrom
yykkibbb:fix/preserve-inner-exception-in-rest-service

Conversation

@yykkibbb

Copy link
Copy Markdown
Contributor

Summary

  • Fixes Don't throw away the inner exception #1437
  • Preserve inner exceptions in RestService.ExecuteOnOneInstanceAsync instead of discarding them
  • Collect caught HttpRequestExceptions and pass them as innerException (single → direct, multiple → AggregateException)
  • Pass the caught exception as innerException for the Unauthorized case

Test plan

  • Added unit tests verifying inner exception preservation for single and multiple URLs
  • All 85 existing unit tests pass

@yykkibbb goal (yykkibbb) requested review from a team as code owners February 18, 2026 09:53
@yykkibbb

Copy link
Copy Markdown
Contributor Author

Hi Matt Howlett (@mhowlett) Henrik Feldt (@haf) Dutchie (@dutchie031) torbjornsk,

I've submitted a PR to address the inner exception preservation issue discussed here. Would appreciate it if you could take a look when you have a chance.

Thank you!

@rayokota

Copy link
Copy Markdown
Member

/sem-approve

@rayokota Robert Yokota (rayokota) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thamks goal (@yykkibbb) , LGTM

@rayokota Robert Yokota (rayokota) merged commit e224e26 into confluentinc:master Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't throw away the inner exception

2 participants