go.mod: update to go1.19 as minimum, and add go1.22.x to GHA #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the oldest version tested in CI, so set this as the minimum version. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
reviewed
Jun 21, 2024
| strategy: | ||
| matrix: | ||
| go-version: [1.19.x, 1.20.x] | ||
| go-version: [1.19.x, 1.21.x, 1.22.x] |
Member
Author
There was a problem hiding this comment.
Yeah, my thinking here was to keep a minimum version (unless we had a strong reason to drop it), then check current versions.
I'm fine with dropping 1.19 by now probably, although "if it works", then 🤷 .
I'll drop the 1.20, and keep the upper-bound to 1.21, 1.22 as suggested.
Member
Author
There was a problem hiding this comment.
oh! I read the diff wrong, thought it was a suggestion, but I already changed to 1.21, 1.22 🤦 😂
AkihiroSuda
approved these changes
Jun 21, 2024
dmcgowan
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: update to go1.19 as minimum
This is the oldest version tested in CI, so set this as the
minimum version.
gha: also test on go1.22.x