test: refactor container_run_systemd_linux_test.go to use Tigron#4708
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Jan 20, 2026
Merged
Conversation
Contributor
Author
|
CI is failing at the moment. I’ll fix it and update this PR shortly. |
haytok
reviewed
Jan 18, 2026
|
|
||
| base.Cmd("inspect", "--format", "{{json .Config.Labels}}", containerName).AssertOutContains("SIGRTMIN+3") | ||
| testCase.Cleanup = func(data test.Data, helpers test.Helpers) { | ||
| containeName := data.Labels().Get("containerName") |
Member
There was a problem hiding this comment.
Please correct other similar typos as well.
Suggested change
| containeName := data.Labels().Get("containerName") | |
| containerName := data.Labels().Get("containerName") |
Contributor
Author
There was a problem hiding this comment.
Sorry about the typos.
I’ve fixed it
| func TestRunWithSystemdTrueDisabled(t *testing.T) { | ||
| if runtime.GOARCH != "amd64" { | ||
| t.Skip("This test is currently broken on arm with no emulation, as the Systemd image being used is amd64 only") | ||
| } |
Member
There was a problem hiding this comment.
Can we use require.Amd64?
Please verify whether other sections can also be rewritten.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out.
I wasn’t aware of require.Amd64
I've fixed it
46 tasks
JoonsooWon
force-pushed
the
issues_4613_container_run_systemd_linux_test.go
branch
2 times, most recently
from
82a18de to
04da5b9
Compare
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
JoonsooWon
force-pushed
the
issues_4613_container_run_systemd_linux_test.go
branch
from
04da5b9 to
43d3536
Compare
Contributor
Author
I've fixed it. @haytok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to Tigron testing framework
related : #4613