test: refactor container_update_linux_test.go to use Tigron#4711
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Jan 21, 2026
Merged
Conversation
haytok
reviewed
Jan 20, 2026
| testCase.Setup = func(data test.Data, helpers test.Helpers) { | ||
| containerName := testutil.Identifier(t) | ||
| data.Labels().Set("containerName", containerName) | ||
| helpers.Ensure("run", "-d", "--name", containerName, testutil.CommonImage, "sleep", "infinity") |
Member
There was a problem hiding this comment.
NIT:
It's better to use nerdtest.Infinity instead of infinity.
https://github.com/containerd/nerdctl/blob/main/pkg/testutil/nerdtest/utilities.go#L40-L44
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
I've fixed it.
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
JoonsooWon
force-pushed
the
issues_4613_container_update_linux_test.go
branch
from
711da1b to
3fa39ae
Compare
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #4613