feat: pods_log support default-container annotation#1002
Open
xingzihai wants to merge 1 commit intocontainers:mainfrom
Open
feat: pods_log support default-container annotation#1002xingzihai wants to merge 1 commit intocontainers:mainfrom
xingzihai wants to merge 1 commit intocontainers:mainfrom
Conversation
This change adds support for the kubectl.kubernetes.io/default-container annotation in pods_log and pods_exec operations. When a pod has multiple containers and the default-container annotation is set, the annotation value is used as the default container for log and exec operations if no container is explicitly specified. This aligns with kubectl's behavior and improves the user experience for multi-container pods. Changes: - Added DefaultContainerAnnotation constant - Added getDefaultContainer helper function - Updated PodsLog to check the annotation when container is not specified - Updated PodsExec to use the helper function for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
kubectl.kubernetes.io/default-containerannotation inpods_logandpods_execoperations.Changes
DefaultContainerAnnotationconstantgetDefaultContainerhelper function to extract the annotation value from pod metadataPodsLogto check the annotation when container is not explicitly specifiedPodsExecto use the helper function for consistencyMotivation
When a pod has multiple containers and the
default-containerannotation is set, users often expect log/exec operations to target that container by default, similar to howkubectlbehaves.This aligns with kubectl's behavior and improves the user experience for multi-container pods.
Testing
Related Issue
Closes #1000
Checklist