refactor(mcp): add NewServerFrom constructor for dependency injection (for module extensibility)#754
Open
mfaizanse wants to merge 4 commits intocontainers:mainfrom
Open
refactor(mcp): add NewServerFrom constructor for dependency injection (for module extensibility)#754mfaizanse wants to merge 4 commits intocontainers:mainfrom
mfaizanse wants to merge 4 commits intocontainers:mainfrom
Conversation
Signed-off-by: Muhammad Faizan <mfaizan.se@gmail.com>
Signed-off-by: Muhammad Faizan <mfaizan.se@gmail.com>
Signed-off-by: Muhammad Faizan <mfaizan.se@gmail.com>
Collaborator
|
Hey 👋 thanks for the PR, mind to update it ? |
Signed-off-by: Muhammad Faizan <mfaizan.se@gmail.com>
Author
@matzew I have resolved the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the MCP server construction to support dependency injection, enabling external Go modules to customize the server when using
kubernetes-mcp-serveras a module dependency.Changes
New Constructor:
NewServerFromAdded a new exported constructor that accepts pre-configured components:
Use Cases
External packages can now:
mcp.Serverwith different options or additional middleware.Example usage