Repository navigation
Conversation
The trafficDistribution block sat after the {{- end }} of the
deployment.enabled check in the Service template. With
deployment.enabled=false (autoscaler or HPA only, targeting an existing
CoreDNS) and service.trafficDistribution set, the template rendered a
document with only trafficDistribution in it, which is not a valid
Kubernetes object and makes the install fail.
Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
In
templates/service.yamlthetrafficDistributionblock sits after the{{- end }}that closes thedeployment.enabledcheck. Withdeployment.enabled: false(running only the autoscaler or HPA against an existing CoreDNS) andservice.trafficDistributionset, the template renders a document that only containstrafficDistribution: PreferClose, which is not a Kubernetes object, sohelm installfails. This moves the block inside the guard.Tests: a new case in
tests/service_test.yamlasserts that nothing is rendered withdeployment.enabled: false. It fails on master (1 document) and passes with the fix.helm unittest --strict,helm lintandct lintpass, and the rendered Service with the deployment enabled is unchanged.Which issues (if any) are related?
None.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.