Disable Customer Deletion if bounded Orders are available#732
Merged
Conversation
Member
dpfaffenbauer
commented
Nov 27, 2018
dpfaffenbauer
commented
| Q | A |
|---|---|
| Bug fix? | yes and no |
| New feature? | yes and no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #707 |
dpfaffenbauer
commented
Nov 27, 2018
dpfaffenbauer
commented
Nov 27, 2018
| * | ||
| * @return boolean | ||
| */ | ||
| public function hasCustomerOrders(CustomerInterface $customer); |
Member
Author
There was a problem hiding this comment.
this could be considered a BC break actually
Member
Author
|
not sure how to proceed here, this needs 5.6.0 to work (pimcore/pimcore#3650) |
dpfaffenbauer
force-pushed
the
issue-707
branch
from
c9c9fd9 to
d20f200
Compare
dpfaffenbauer
force-pushed
the
issue-707
branch
from
cc68c69 to
80f2193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.