feat(demo): add button to reproduce labelmap removal crash#2566
Merged
wayfarer3130 merged 2 commits intoJun 23, 2026
Merged
Conversation
Contributor
|
This PR is to demonstrate a bug we found, we didn't succeed to understand the logic to fix the bug |
sedghi
approved these changes
Jan 23, 2026
Collaborator
977c40c to
6086ee2
Compare
wayfarer3130
reviewed
Feb 9, 2026
wayfarer3130
left a comment
Collaborator
There was a problem hiding this comment.
This appears to be an empty change based on the 3.12 release version. Can you close, or else look at the purple background issue I posted in the comments/
Contributor
|
@wayfarer3130 the initial bug is fixed, The other bug I have is when I remove the segmentation I loose my SlabThinkness see : However it is probably another bug, can we merge this PR to get this button to remove segmentation and then we will see what we can do on this viewport property loss |
wayfarer3130
approved these changes
Jun 23, 2026
wayfarer3130
added a commit
that referenced
this pull request
Jun 24, 2026
Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
This PR shows a crash that occurs when removing a segmentation representation from a MIP (Maximum Intensity Projection) viewport.
In the
SEGMENTATION_REPRESENTATION_REMOVEDevent listener, the code attempts to immediately re-create a volume actor usingcreateVolumeActor. However, it passes theuid(which is the Actor UID being removed) as thevolumeId.For derived volumes (like labelmaps generated in memory), this incorrect ID causes
volumeLoaderto fail, often throwing the error:Error: ImageIds must be provided to create a streaming image volume. This happens because the loader cannot find the derived volume by that ID and falls back to the streaming loader, which requires ImageIds.Changes & Results
Added a button for trying to delete the Labelmap eepresentation and cause the error.
Testing
In the example labelmapMip, add a Labelmap Representation then click on the button "Delete Labelmap Representation" wich try to delete the labelmap and shows the error
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment