Skip to content

fix(security): add undici and linkify-it to pnpm-workspace.yaml as resolutions#2776

Merged
sedghi merged 2 commits into
cornerstonejs:mainfrom
jbocce:fix/OHIF-2659-cs3d-security-patches
Jun 29, 2026
Merged

fix(security): add undici and linkify-it to pnpm-workspace.yaml as resolutions#2776
sedghi merged 2 commits into
cornerstonejs:mainfrom
jbocce:fix/OHIF-2659-cs3d-security-patches

Conversation

@jbocce

@jbocce jbocce commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Context

GHSA-vxpw-j846-p89q

GHSA-22p9-wv53-3rq4

Changes & Results

Use resolutions.

Testing

Automated tests should pass.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Summary by CodeRabbit

  • Chores
    • Updated workspace dependency overrides to pin two packages to specific versions, helping keep builds and installs consistent.

@jbocce jbocce requested a review from sedghi June 29, 2026 07:42
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 76c87145-8e1a-4bd8-941d-52d29c5790ed

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc8f0d and 65a7bc9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Two dependency version overrides are added to pnpm-workspace.yaml: undici is pinned to 6.27.0 and linkify-it is pinned to 5.0.1.

Dependency Version Pins

Layer / File(s) Summary
Add undici and linkify-it overrides
pnpm-workspace.yaml
Adds undici: 6.27.0 and linkify-it: 5.0.1 to the workspace overrides section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • sedghi

Poem

🐇 Two packages now pinned, no more drift at night,
undici and linkify-it locked down tight.
The workspace YAML grows just two lines more,
A bunny's small patch to keep versions in store!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific, accurate, and matches the dependency override security fix in the PR.
Description check ✅ Passed The description follows the template and covers context, changes, testing, and checklist, though the testing/environment details are brief.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sedghi sedghi merged commit f6c001c into cornerstonejs:main Jun 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants