[Bug]: panic at upgrade height if there is listener

[beer-1]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

A cosmos app is panicking at upgrade height when it has abci listeners.

These lines are executed even the internalFinalizeBlock return the errors and res is nil

cosmos-sdk/baseapp/abci.go

Lines 860 to 862 in 7b9d2ff

	if err := streamingListener.ListenFinalizeBlock(app.finalizeBlockState.Context(), *req, *res); err != nil {
	app.logger.Error("ListenFinalizeBlock listening hook failed", "height", req.Height, "err", err)
	}

so *res make the node panic and it sometimes breaking our upgrade checker logics.

Cosmos SDK Version

0.50

How to reproduce?

register abci listener and create upgrade proposal and wait upgrade height

[yihuang]

fixed by: #23879

[beer-1]

Ob good to know that, it will be backported?

[yihuang]

Ob good to know that, it will be backported?

It seems have been back-ported to 0.53 and 0.50

[beer-1]

Thanks for confirmation, just need to wait the release :)

[Olshansk]

@beer-1 Thanks for raising this!

@yihuang Our team is on v0.50.13.

The latest official release is from Mar 12th, but this was merged in afterwards. Do you know when the rc might be promoted?