perf(context): avoid unnecessary copies in KVStore, TransientStore and CacheContext methods

[testinginprod]

Description

Avoids unnecessary context copies on the KVStore, TransientStore and CacheContext methods, whilst retaining the copy semantics.

_@_-MBP types % benchstat before_cache_context.txt after_cache_context.txt 
name                     old time/op  new time/op  delta
Context_CacheContext-10  1.72µs ± 5%  1.69µs ± 6%  -1.71%  (p=0.001 n=17+18)


_@_-MBP types % benchstat before_kv_context.txt after_kv_context.txt   
name                old time/op  new time/op  delta
Context_KVStore-10   136ns ± 4%    81ns ± 3%  -40.46%  (p=0.000 n=18+18)


_@_-MBP types % benchstat before_transient_context.txt after_transient_context.txt
name                       old time/op  new time/op  delta
Context_TransientStore-10   135ns ± 2%    82ns ± 2%  -39.59%  (p=0.000 n=18+18)

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[github-actions]

Change potentially affects state.

Call sequence:

(github.com/cosmos/cosmos-sdk/types.Context).CacheContext (types/context.go:293)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).getContextForTx (types/context.go:570)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (types/context.go:618)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).DeliverTx (types/context.go:326)

[sonarqubecloud]

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[yihuang]

LGTM

[tac0turtle]

I don't fully understand why this added so much overhead, but happy to see it reduced

[testinginprod]

I don't fully understand why this added so much overhead, but happy to see it reduced

sdk.Context is fully implemented with value receives and is passed around like a value rather than being passed with pointers, sdk.Context is a huge bag of values whose size cannot be ignored I guess... I think it might be a problem considering how frequently we pass it around (antes, keepers, etc.), each time we're making a copy.