Skip to content

feat(collections): implement pagination#14468

Merged
testinginprod merged 17 commits into
mainfrom
tip/collections-pagination
Jan 6, 2023
Merged

feat(collections): implement pagination#14468
testinginprod merged 17 commits into
mainfrom
tip/collections-pagination

Conversation

@testinginprod
Copy link
Copy Markdown
Contributor

Description

Implements pagination logic for a collection.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod requested a review from a team January 3, 2023 15:38
@ghost ghost self-requested a review January 3, 2023 15:38
@ghost ghost requested review from JeancarloBarrios and julienrbrt and removed request for a team January 3, 2023 15:38
@aaronc aaronc assigned aaronc and unassigned aaronc Jan 3, 2023
Comment thread types/query/collections_pagination.go
Comment thread types/query/collections_pagination.go Outdated
Comment thread types/query/collections_pagination.go Outdated
Comment thread types/query/collections_pagination.go Outdated
Comment thread types/query/collections_pagination.go Outdated
Comment thread types/query/collections_pagination.go Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 5, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@testinginprod testinginprod enabled auto-merge (squash) January 6, 2023 10:14
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 6, 2023

[Cosmos SDK - Collections] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 6, 2023

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@testinginprod testinginprod merged commit f771f20 into main Jan 6, 2023
@testinginprod testinginprod deleted the tip/collections-pagination branch January 6, 2023 11:08
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: testinginprod <testinginprod@somewhere.idk>
@samricotta samricotta mentioned this pull request May 24, 2023
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants