feat!: upstream expedited proposals#14720
Conversation
julienrbrt
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if burnDeposits { | ||
| keeper.DeleteAndBurnDeposits(ctx, proposal.Id) | ||
| } else { | ||
| keeper.RefundAndDeleteDeposits(ctx, proposal.Id) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| } else { | ||
| keeper.RefundAndDeleteDeposits(ctx, proposal.Id) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| endTime := proposal.VotingStartTime.Add(*params.VotingPeriod) | ||
| proposal.VotingEndTime = &endTime | ||
|
|
||
| keeper.InsertActiveProposalQueue(ctx, proposal.Id, *proposal.VotingEndTime) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| keeper.InsertActiveProposalQueue(ctx, proposal.Id, *proposal.VotingEndTime) | ||
|
|
||
| tagValue = types.AttributeValueExpeditedProposalRejected | ||
| logMsg = "expedited proposal converted to regular" |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
@julienrbrt One of the things Osmosis also implemented was a higher deposit amount for expedited proposals. This, paired with the minimum initial deposit ratio, would help remedy spam proposals. We (KYVE) would love to see this included 🙌🏻 |
ghost
requested review from
a team,
alexanderbez and
facundomedica
and removed request for
a team
julienrbrt
force-pushed
the
julien/expedited-proposal-upstream
branch
from
6ea123b to
d3dc533
Compare
| @@ -1,3 +1,5 @@ | |||
| // TODO update this file | |||
There was a problem hiding this comment.
Upstreaming the tests here.
| if passes { | ||
| keeper.RemoveFromActiveProposalQueue(ctx, proposal.Id, *proposal.VotingEndTime) | ||
|
|
||
| switch { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
looks good, left one ask on the docs, its minor
Minimal backport of cosmos#14720
7 participants
Description
Closes: #14694
As per #14720 (comment), up streaming osmosis-labs@8b021d2 as well
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change