fix: replace IsEqual with Equal#14739
Merged
tac0turtle merged 6 commits intoJan 24, 2023
Merged
Conversation
EmilGeorgiev
force-pushed
the
EmilGeorgiev/fix-replace-IsEqual-with-Equal
branch
from
5066965 to
ba6478b
Compare
github-actions
Bot
added
C:x/auth
C:x/bank
C:x/distribution
EmilGeorgiev
changed the title
EmilGeorgiev
force-pushed
the
EmilGeorgiev/fix-replace-IsEqual-with-Equal
branch
from
07ad1cb to
0426409
Compare
julienrbrt
reviewed
Jan 23, 2023
The method IsEqual throw panic if the denoms of two coins are not equal. This lead to unexpected behavior of the, becasue in most of the cases the users expected an error to be returned Issue: cosmos#3246
Rename method IsEqual of the type Coins to Equal to follow standardize terminology for 'Equal; function on structs Refs: cosmos#3246
EmilGeorgiev
force-pushed
the
EmilGeorgiev/fix-replace-IsEqual-with-Equal
branch
from
dd54135 to
e693abb
Compare
ghost
requested review from
a team,
aaronc and
testinginprod
and removed request for
a team
Contributor
Author
|
I don't have write access to the repository, so I can't merge the PR. |
tac0turtle
reviewed
Jan 24, 2023
tac0turtle
approved these changes
Jan 24, 2023
Contributor
|
thanks for the contribution |
5 tasks
5 tasks
lukasz-zimnoch
added a commit
to mezo-org/mezod
that referenced
this pull request
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #3246
replace the method Coin.IsEqual with Coin.Equal. The main difference between the two methods is that the first one rise a panic when denoms are not equal. This panic may lead to unexpected behavior
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change