refactor: x/upgrade to standalone module#14764
Merged
Merged
Conversation
github-actions
Bot
added
C:CLI
C:Cosmovisor
added 4 commits
January 25, 2023 14:27
ghost
requested review from
a team,
kocubinski and
testinginprod
and removed request for
a team
added 2 commits
January 25, 2023 16:15
This reverts commit 9ac4642.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) | ||
| bufHdr := (*reflect.SliceHeader)(unsafe.Pointer(&buf)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| // must not be altered after this function is called as it will cause a segmentation fault. | ||
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
likhita-809
commented
Jan 25, 2023
|
[Cosmos SDK - x/upgrade] Kudos, SonarCloud Quality Gate passed!
|
julienrbrt
reviewed
Jan 26, 2023
Contributor
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
lgtm, except cosmovisor changes should be reverted.
…ita/upgrade-go-mod
added 2 commits
January 27, 2023 10:59
julienrbrt
reviewed
Jan 27, 2023
added 2 commits
January 27, 2023 15:45
…ita/upgrade-go-mod
likhita-809
commented
Jan 27, 2023
julienrbrt
approved these changes
Jan 27, 2023
added 2 commits
January 27, 2023 15:54
atheeshp
approved these changes
Jan 27, 2023
added 2 commits
January 27, 2023 18:58
…ita/upgrade-go-mod
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
12 tasks
lukasz-zimnoch
added a commit
to mezo-org/mezod
that referenced
this pull request
Jul 31, 2024
In Cosmos `0.50.x`, the aforementioned `upgrade` package became a standalone module placed under `cosmossdk.io` namespace. Here we adjust our codebase to this change. See: cosmos/cosmos-sdk#14764 and https://docs.cosmos.network/main/build/migrations/upgrading#extract-upgrade-to-a-standalone-module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14560
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change