feat: emit more data in prom metrics

[dhanusaputra]

Description

Closes: #15593

---

Workscope

• add go version to prometheus metrics
• add software version to metrics
• add height of next upgrade
• see if anything else can be added

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

lgtm, thank you!
(Edit: I'll try it out with simd in a bit)

[julienrbrt]

If we only use the height, we do not need to parse the rest.

[julienrbrt]

before

after

Do we want this information as global label actually @tac0turtle?

[tac0turtle]

hmm we shouldnt have it as a global but instead have a single metric

[tac0turtle]

this can go in the upgrade module. helps avoid the upgrade dep in server

[julienrbrt]

note: I have tried to check the upgrade height, have you @dhanusaputra?

[julienrbrt]

I have not tried if it works, but if it does it will only work for app wiring app (app_v2). Could you add this additionally to the app.go?

[julienrbrt]

Suggested change

	telemetry.SetGaugeWithLabels([]string{"server", "info"}, 1, []metrics.Label{telemetry.NewLabel("upgrade_height", strconv.FormatInt(upgradePlan.Height, 10))})
	if upgradePlan.Height > 0 {
	telemetry.SetGaugeWithLabels([]string{"server", "info"}, 1, []metrics.Label{telemetry.NewLabel("upgrade_height", strconv.FormatInt(upgradePlan.Height, 10))})
	}

Prob need this because the app is instantiated the first time with a temporary directory, for getting the application encoding (

cosmos-sdk/simapp/simd/cmd/root.go

Line 47 in c1ea84d

tempApp := simapp.NewSimApp(log.NewNopLogger(), dbm.NewMemDB(), nil, true, simtestutil.NewAppOptionsWithFlagHome(tempDir()))

)

[dhanusaputra]

note: I have tried to check the upgrade height, have you @dhanusaputra?

not yet, will try run the simapp with better PC soon

[tac0turtle]

this will only set it on startup, we should set it where its called the plan is set. also this assumes the application is using depinject which isnt the case yet.

cosmos-sdk/x/upgrade/keeper/keeper.go

Line 194 in 92738c0

func (k Keeper) ScheduleUpgrade(ctx sdk.Context, plan types.Plan) error {

[dhanusaputra]

no luck testing the upgrade height
tried this guide but the cosmovisor keep running without dumping new version, not sure why

[tac0turtle]

utACK