refactor(abci): add msg index to event

[tac0turtle]

Description

Closes: #15017

Logs now do not contain events associated to messages. The msg_index was added to the event itself, this avoids duplication of data

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

utACK

[julienrbrt]

utACK.

[alexanderbez]

You might as well do this in the Comet 0.38 branch as it'll just create more work of us if you do it against main.

[tac0turtle]

Could we merge it into main. Happy to handle the merge into 0.38.

[alexanderbez]

my point is there is no point to merge to main -- we're literally going to do the exact same change in the base branch immediately.

[tac0turtle]

my point is there is no point to merge to main -- we're literally going to do the exact same change in the base immediately.

this is orthagonal to 0.38, i dont get what the overlap is?

[facundomedica]

LGTM, do we need to add a note in the UPGRADING.md because it might break some tooling?

[facundomedica]

It's failing because it's matching against the raw logs, I've fix one in which I iterate through events to find the right event type. But maybe we would like to have an easier way like doing json.Marshal to get a "raw log"

[tac0turtle]

It's failing because it's matching against the raw logs, I've fix one in which I iterate through events to find the right event type. But maybe we would like to have an easier way like doing json.Marshal to get a "raw log"

i was going to rewrite these tests in a dfferent pr to unit tests, dont think these need to be e2e

[facundomedica]

i was going to rewrite these tests in a dfferent pr to unit tests, dont think these need to be e2e

lmk if you'd like me to revert my commits