test: increase nondeterminism tries per seed by 1#15883
Merged
Conversation
It used to be set to 5 tries, but that was taking over an hour. After some improvements (particularly #15875 and #15862), it's running much faster due to reduced allocations. Since the nondeterminism tests are no longer the bottleneck, increase the tries per seed by 1 so that it is still no longer the bottleneck, but so that we also get more confidence that results are deterministic.
ghost
requested review from
a team and
julienrbrt
and removed request for
a team
tac0turtle
approved these changes
Apr 19, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It used to be set to 5 tries, but that was taking over an hour. After some improvements (particularly #15875 and #15862), it's running much faster due to reduced allocations.
Since the nondeterminism tests are no longer the bottleneck, increase the tries per seed by 1 so that it is still no longer the bottleneck, but so that we also get more confidence that results are deterministic.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...