refactor!: rm GetSignBytes#16062
Merged
Merged
Conversation
78bd2be to
025d165
Compare
f5a89ab to
f7707f1
Compare
f7707f1 to
3d7a2e7
Compare
tac0turtle
approved these changes
May 30, 2023
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
utACK. the encoding tests are passing but later on during QA ill pull out a ledger to test things with
alexanderbez
approved these changes
May 30, 2023
Contributor
Author
|
This advanced #13025 |
9 tasks
3 tasks
5 tasks
bennyzhe
pushed a commit
to shentufoundation/shentu
that referenced
this pull request
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the legacy amino JSON codec is now deprecated (#16110) and no longer used in production code paths (#16024) we can now remove a lot of unused code, code smells (global vars), and cyclic module dependencies.
The following cyclic dependencies are removed compared to
maincosmos/cosmos-sdk
GetSignBytesimplementations from messages which were using them.x/auth
RegressionTestingAminoCodecto x/auth/legacytx package to replace the global codecs for use in regression tests. This should be deleted eventually.cosmossdk.io/api
Coinsfields ensuring legacy consistency.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change