chore: finish removing all exported *SortJSON usages#16497
Merged
Conversation
ghost
requested review from
a team,
aaronc and
julienrbrt
and removed request for
a team
odeke-em
force-pushed
the
all-eradicate-exported-SortJSON
branch
from
f530195 to
dbba596
Compare
Contributor
Author
|
/cc @elias-orijtech |
julienrbrt
reviewed
Jun 12, 2023
tac0turtle
approved these changes
Jun 12, 2023
tac0turtle
left a comment
tac0turtle
left a comment
Contributor
There was a problem hiding this comment.
LGTM, once we move the changelog entry location we can merge this
odeke-em
force-pushed
the
all-eradicate-exported-SortJSON
branch
2 times, most recently
from
57b1629 to
344986a
Compare
This change removes the last vestiges of
sdk.SortJSON and sdk.MustSortJSON,
and while here also removed some unnecessary instances which already
used json.MarshalIndent(...) which produces already sorted JSON.
odeke-em
force-pushed
the
all-eradicate-exported-SortJSON
branch
from
344986a to
4a875c2
Compare
julienrbrt
approved these changes
Jun 12, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
(cherry picked from commit f5a596c) # Conflicts: # CHANGELOG.md
tac0turtle
pushed a commit
that referenced
this pull request
Jun 12, 2023
#16502) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the last vestiges of
and while here also removed some unnecessary instances which already used json.MarshalIndent(...) which produces already sorted JSON.