fix!: Ensure Handler Exists for Messages#16613
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
832
to
+838
| return sdk.GasInfo{}, nil, nil, err | ||
| } | ||
|
|
||
| for _, msg := range msgs { | ||
| handler := app.msgServiceRouter.Handler(msg) | ||
| if handler == nil { | ||
| return sdk.GasInfo{}, nil, nil, errorsmod.Wrapf(sdkerrors.ErrUnknownRequest, "no message handler found for %T", msg) |
Contributor
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:778)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:708)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:648)
ghost
requested review from
a team,
facundomedica and
samricotta
and removed request for
a team
mergify Bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
(cherry picked from commit 6f9152d) # Conflicts: # CHANGELOG.md
julienrbrt
added a commit
that referenced
this pull request
Jun 19, 2023
tac0turtle
reviewed
Jun 20, 2023
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
While simple could we add a test case or two
Contributor
Author
|
The tests I modified ensure a handler exists, otherwise they would fail. Happy to add more explicit tests though! |
Contributor
|
oh sorry github pointed me to one file changed instead of four |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16610
Update
runTxto ensure each message has a registered handler.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change