feat!: simplify AppModuleBasic interface for CLI#16890
Merged
Merged
Conversation
julienrbrt
commented
Jul 9, 2023
| if cmd := b.GetTxCmd(); cmd != nil { | ||
| rootTxCmd.AddCommand(cmd) | ||
| if mod, ok := b.(interface { | ||
| GetTxCmd() *cobra.Command |
Contributor
Author
There was a problem hiding this comment.
For reference, this replicates the behavior from the Core API Adapter:
cosmos-sdk/types/module/core_module.go
Lines 137 to 145 in adb03ec
This comment has been minimized.
This comment has been minimized.
tac0turtle
approved these changes
Jul 10, 2023
Comment on lines
83
to
85
| // GetTxCmd returns no root tx command for the mint module. | ||
| func (AppModuleBasic) GetTxCmd() *cobra.Command { return nil } | ||
|
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit f3e4697) # Conflicts: # CHANGELOG.md # x/evidence/go.mod # x/evidence/go.sum # x/nft/go.mod # x/nft/go.sum
julienrbrt
added a commit
that referenced
this pull request
Jul 10, 2023
…16904) Co-authored-by: Julien Robert <julien@rbrt.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #16754 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change