feat(gov): Add proposal failed reason#16976
Merged
Merged
Conversation
ghost
requested review from
a team,
aaronc and
samricotta
and removed request for
a team
Contributor
|
Can you fix the failing test and add a changelog under unreleased features? |
julienrbrt
reviewed
Jul 13, 2023
|
|
||
| // failed_reason defines the reason why the proposal failed | ||
| // | ||
| // Since: cosmos-sdk 0.50 |
Contributor
There was a problem hiding this comment.
@tac0turtle is this something we get into 0.50 or wait until 0.51?
Contributor
There was a problem hiding this comment.
The changeset is pretty trivial. Would be a nice win to get this in
…smos-sdk into gov-add-reasonfailed
Contributor
Author
Done! It turns out the failing test was just a misaligned line. Hope the changelog is also ok. |
julienrbrt
reviewed
Jul 13, 2023
alexanderbez
approved these changes
Jul 13, 2023
|
|
||
| // failed_reason defines the reason why the proposal failed | ||
| // | ||
| // Since: cosmos-sdk 0.50 |
Contributor
There was a problem hiding this comment.
The changeset is pretty trivial. Would be a nice win to get this in
julienrbrt
approved these changes
Jul 13, 2023
Contributor
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
lgtm! Thank you for tackling this.
mergify Bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 80e3c7a)
julienrbrt
pushed a commit
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add "failed_reason" field to gov proposal.
Closes: #16877
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change