feat(gov): autocli query support#16987
Merged
Merged
Conversation
julienrbrt
commented
Jul 13, 2023
| tallyParams := v1.NewTallyParams(params.Quorum, params.Threshold, params.VetoThreshold) | ||
| response.TallyParams = &tallyParams | ||
|
|
||
| default: |
Contributor
Author
There was a problem hiding this comment.
This allows to pass no parameters but still return the whole params.
17 tasks
ghost
requested review from
a team,
JeancarloBarrios and
likhita-809
and removed request for
a team
tac0turtle
approved these changes
Jul 14, 2023
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
Left one question but otherwise looks good
| GetCmdQueryVotes(), | ||
| GetCmdQueryParams(), | ||
| GetCmdQueryParam(), | ||
| GetCmdQueryProposer(), |
Contributor
There was a problem hiding this comment.
Reason for this staying?
Contributor
Author
There was a problem hiding this comment.
Yeah, it queries events and filters (
cosmos-sdk/x/gov/client/utils/query.go
Line 165 in 90b3907
In this case, we cannot use AutoCLI. I'll implement #16836, to be able to wire it back in gov.
Contributor
Author
There was a problem hiding this comment.
Now that proposers are in the proposals, we could actually introduce a query for it too.
mergify Bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
(cherry picked from commit 8cf483a) # Conflicts: # x/circuit/go.mod # x/circuit/go.sum # x/evidence/go.mod # x/evidence/go.sum # x/gov/client/cli/query.go
julienrbrt
added a commit
that referenced
this pull request
Jul 14, 2023
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref: #15901
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change