Skip to content

feat: add core and api for PreBlock#17468

Merged
tac0turtle merged 2 commits into
cosmos:mainfrom
mmsqe:pre-begin-dep
Aug 20, 2023
Merged

feat: add core and api for PreBlock#17468
tac0turtle merged 2 commits into
cosmos:mainfrom
mmsqe:pre-begin-dep

Conversation

@mmsqe
Copy link
Copy Markdown
Collaborator

@mmsqe mmsqe commented Aug 20, 2023

Description

Updates #17421

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

mmsqe
mmsqe commented Aug 20, 2023
View reviewed changes
Comment thread core/CHANGELOG.md Outdated
@mmsqe mmsqe marked this pull request as ready for review August 20, 2023 13:37
@mmsqe mmsqe requested a review from a team August 20, 2023 13:37
@ghost ghost requested review from a team, julienrbrt and tac0turtle and removed request for a team August 20, 2023 13:37
@julienrbrt julienrbrt self-assigned this Aug 20, 2023
julienrbrt
julienrbrt approved these changes Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but let's get more approval.

tac0turtle
tac0turtle reviewed Aug 20, 2023
View reviewed changes
Comment thread core/appmodule/module.go
@tac0turtle tac0turtle added this pull request to the merge queue Aug 20, 2023
Merged via the queue into cosmos:main with commit 1bd3705 Aug 20, 2023
@julienrbrt
Copy link
Copy Markdown
Contributor

julienrbrt commented Aug 20, 2023

Writing that here as a reminder for myself.

With changes like this we need to start to create a compatibility matrix of core x SDK. As for instance a module implementing PreBlock from core v0.11.0, in a v0.47 chain will have no effect.

@mmsqe
Copy link
Copy Markdown
Collaborator Author

mmsqe commented Aug 21, 2023

Writing that here as a reminder for myself.

Maybe we could also remove UpgradeModule later

@julienrbrt julienrbrt mentioned this pull request Aug 21, 2023
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 3, 2024
Merged
12 tasks
sainoe pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Mar 12, 2025
@mmsqe @sainoe
feat: add core and api for PreBlock (cosmos#17468)
3c009c6
maxim-inj pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Mar 17, 2025
@mmsqe @maxim-inj
feat: add core and api for PreBlock (cosmos#17468)
c661547
maxim-inj pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request May 4, 2025
@mmsqe @maxim-inj
feat: add core and api for PreBlock (cosmos#17468)
04b470c
maxim-inj added a commit to InjectiveLabs/cosmos-sdk that referenced this pull request May 4, 2025
@maxim-inj @sainoe
@mmsqe @julienrbrt @JeancarloBarrios @johnletey @coderabbitai @tac0turtle @facundomedica
v0.50.x EVM meets cometbft v1 (#56)
38796fc 
* * Bump SDK to use CometBFT to v1.0.1 and CometBFT api
* Add CometBFT v1 buf registry commit to buf.yaml
* Update tendermint to comet import in proto files
* Replace tendermint to comet imports in Go files
* Remove deprecated sr25519 support starting from CometBFT v1.0.1
* Update SDK go.mod to use local ./api, which is upgraded to Comet v1, instead of cosmossdk.io/api v0.7.5
* Generate proto and pulsar files and remove tendermint from ./proto

* fix API breaks of ABCI types in baseapp

* import cometBFT protocolbuffers in api

* fix node comet wrapper breaking changes

* gen protos and fix nits in abci tests

* generate proto and pulsar files

* * Bump comet to v1 in x/nft, x/feegrant/, x/evidence and store
* Remove go toolchain from go.mod files

* Revert renaming of query types in store by error

* * Update buf.yaml to latest Comet BSR commit
* Generate pulsar files
* Fix ABCI unit test in baseapp
* Fix genesis tests
* Remove Go toolchains
* Fix remaining breaking changes of Comet v1 ABCI types

* Add synchrony and features params to MsgUpdateParams in x/consensus

* feat: add core and api for PreBlock (cosmos#17468)

* feat(api): add autocli options to enhance custom commands (cosmos#17033)

* feat(client): add positional optional to client v2 (cosmos#16316)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix slashing UT

* feat(client/v2): override short description in generated command (cosmos#20266)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* refactor(baseapp): create checktx handler (cosmos#21979)

* fix testdata in autocli msg tests

* fix ABCI tests broken by CheckTxHandler PR (cosmos#21979)

* fix broken tests in x/bank introduced by 59f4bfe

* * Fix errors in store tests introduced by 5c206aa which adds new commitSync bool and is never tested
* Fix building errors in integration tests introduced by f173a77 which breaks all integration tests using the bank keeper
* Remove deprecated MsgEditValidator ValidateBasic function which was breaking some related CLI test in x/staking

* fix(baseapp): return events from preblocker in FinalizeBlockResponse (cosmos#21159)

* * Fix ante tests in x/auth broken by c053612
* Update base block gas in block gas tests

* * Update GH worfklow to work with Go 1.23.5
* Add missing bank module to simapp's EndBlockers causing test-simapp to fail in GH workflow

* remove unwanted file addition

* Fix E2E tests that were failing in majority due to changes in BroadcastTxSync in Comet V1

* bump cosmos-db to v1.0.1

* run go mod tidy for all submodules

* chore: update cometbft to v1.0.1-inj exact tag.

refresh go.mod and go.sum dependencies.

* chore: post-rebase code patches

* missing merge in auth
* gogoproto extension double-reg issue
* grpc/pulsar re-generated (Note: missed that during #53)
* minimise diff to only cometbft1 related changes
* fix preblocker events (keep old behavior)
* fix store tests

---------

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com>
Co-authored-by: John Letey <j@letey.de>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kocubinski kocubinski

@alexanderbez alexanderbez

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mmsqe @julienrbrt @tac0turtle @kocubinski @alexanderbez