feat: CV Close databases opened by cosmos-sdk during BaseApp shutdown#17667
Merged
Conversation
ghost
requested review from
a team,
atheeshp and
tac0turtle
and removed request for
a team
chillyvee
force-pushed
the
cv_closedb
branch
from
aa824c5 to
0648035
Compare
20 tasks
chillyvee
force-pushed
the
cv_closedb
branch
from
0648035 to
6529639
Compare
yihuang
approved these changes
Sep 10, 2023
julienrbrt
approved these changes
Sep 10, 2023
Contributor
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
lgtm! Can you fix the linting?
tac0turtle
approved these changes
Sep 10, 2023
chillyvee
force-pushed
the
cv_closedb
branch
from
6529639 to
b8ebbba
Compare
Contributor
Author
fumpted |
chillyvee
force-pushed
the
cv_closedb
branch
from
b8ebbba to
5367edb
Compare
julienrbrt
pushed a commit
that referenced
this pull request
Sep 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close databases opened by cosmos-sdk during BaseApp shutdown.
Code previously reviewed in #17094
Only code for database close in this PR for use in current and past cosmos-sdk releases.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change