fix(gov): fail proposal when implementation not found#17873
Merged
Conversation
ghost
requested review from
a team,
atheeshp and
likhita-809
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
alexanderbez
approved these changes
Sep 25, 2023
likhita-809
approved these changes
Sep 26, 2023
Contributor
likhita-809
left a comment
likhita-809
left a comment
There was a problem hiding this comment.
one qq, otherwise lgtm
colin-axner
approved these changes
Sep 26, 2023
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
ACK, tested with our e2e's:
proposal failed to decode; deleted expedited=false module=x/gov proposal=2 results="collections: encoding error: value decode: no concrete type registered for type URL /ibc.core.client.v1.UpgradeProposal against interface *v1beta1.Content" title=title
mergify Bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
(cherry picked from commit 2f7bc22) # Conflicts: # CHANGELOG.md
julienrbrt
added a commit
that referenced
this pull request
Sep 26, 2023
… (#17882) Co-authored-by: Julien Robert <julien@rbrt.fr>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds logic to fail a proposal when its message isn't registered.
This can typically happen after an upgrade, the chain developer removed a type that were used in a proposal on chain.
Credits to @colin-axner that found the issue on v0.50 rc.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change