refactor(x/gov)!: let hooks return an error#18173
Merged
Merged
Conversation
ghost
requested review from
a team,
facundomedica and
samricotta
and removed request for
a team
julienrbrt
commented
Oct 19, 2023
|
|
||
| ### API Breaking Changes | ||
|
|
||
| * (x/gov) [#18173](https://github.com/cosmos/cosmos-sdk/pull/18173) Gov Hooks now returns error and are "blocking" if they fail. Expect for `AfterProposalFailedMinDeposit` and `AfterProposalVotingPeriodEnded` that will log the error and continue. |
Contributor
Author
There was a problem hiding this comment.
Something to be explained when this is done: #10453
tac0turtle
approved these changes
Oct 19, 2023
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
should we open an issue to return errors on all hooks?
Contributor
Author
Can do here too if you want, but I think they already do 🤔 |
facundomedica
approved these changes
Oct 19, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit 4121869) # Conflicts: # CHANGELOG.md
Contributor
Author
Just checked, and they indeed all do, only gov was missing. |
tac0turtle
pushed a commit
that referenced
this pull request
Oct 19, 2023
12 tasks
mpoke
pushed a commit
that referenced
this pull request
Feb 1, 2024
mattverse
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Feb 6, 2024
…-ics-lsm branch (cosmos#19305)
czarcas7ic
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Mar 9, 2024
* fix(x/gov): Backport of pull request cosmos#18173 to feature/v.0.47.x-ics-lsm branch (cosmos#19305) * update changelog --------- Co-authored-by: Dusan Maksimovic <94966669+dusan-maksimovic@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Adam Tucker <adam@osmosis.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A-9
No fix for v0.47 as we cannot introduce an api breaking change and cannot know if the hook failed.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change