refactor(x/staking): check duplicate addresses in StakeAuthorization's params

[lukema95]

Description

Closes: #XXXX

We should check the lists in the allow_list and deny_list parameters of StakeAuthorization for duplicate addresses.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes

  • Enhanced validation to prevent duplicates in allowed and denied validator lists, ensuring more robust stake authorizations.

• Tests

  • Updated TestAuthzAuthorizations to include checks for the new validation logic.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve updates to the validation logic in a staking module, specifically for stake authorizations. The code now checks for duplicates not only in the list of allowed validators but also in the list of denied validators. If duplicates are found in either list, an error is generated. Additionally, the test suite has been updated to include checks for these new validation rules, ensuring that stake authorizations correctly handle duplicate entries in both allowed and denied lists.

Changes

File	Change Summary
x/staking/types/authz.go	Updated validation logic to check for duplicates in both allowed and denied validator slices.
x/staking/types/authz_test.go	Enhanced test function to include error checks for duplicate validator addresses in both allowed and denied slices.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f6df368 and 9cd02a3.

Files selected for processing (2)

• x/staking/types/authz.go (1 hunks)
• x/staking/types/authz_test.go (1 hunks)

Additional comments: 2

x/staking/types/authz.go (1)

• 165-187: The changes correctly implement the validation logic to prevent duplicate addresses in the allow_list and deny_list. The use of maps to track already encountered addresses is an efficient way to detect duplicates.

x/staking/types/authz_test.go (1)

• 42-51: The added test cases correctly check for errors when duplicates are present in the allow_list and deny_list. Ensure that there are also test cases that verify the behavior when there are no duplicates to ensure the validation logic works as expected in all scenarios.

[julienrbrt]

lgtm, thank you!