feat(client/keys): check multisig key duplicate by levisyin · Pull Request #18703 · cosmos/cosmos-sdk

levisyin · 2023-12-12T05:48:42Z

Description

This pr added a support for checking <appd> keys multisig keys duplicate.

<appd> keys add
<appd> keys show

And btw, add simapp/simd/simd to .gitignore

coderabbitai · 2023-12-12T05:48:49Z

Walkthrough

The recent updates include enhancements to the client/keys module to prevent duplicate keys in multisig configurations, improvements to genesis validation in the x/gov module, and a shift from panicking to error handling in the x/bank, x/distribution, and x/slashing modules. These changes aim to improve the robustness and reliability of the codebase by ensuring better error management and validation processes.

Changes

File(s)	Summary
`.gitignore`	Added entry to ignore the "simapp/simd/simd" directory.
`client/keys/add.go`, `client/keys/show.go`	Modified logic to use a `keyFilter` map for checking duplicate keys and updated variable naming.
`client/keys/add_test.go`	Added `Test_runAddCmdMultisig` function to test multisig key addition and error handling for duplicates.
`CHANGELOG.md`	Documented enhancements to `client/keys` module, genesis validation in `x/gov`, and error handling improvements in `x/bank`, `x/distribution`, and `x/slashing`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can reply to a review comment made by CodeRabbit.
You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

julienrbrt

For keys add it makes sense for keys show not so sure. If people rely on this weird behavior, then 0.51 won't work for them anymore.

levisyin · 2023-12-12T10:07:13Z

For keys add it makes sense for keys show not so sure. If people rely on this weird behavior they 0.51 won't work for them anymore.

What about showing warning message instead of return error(break the process)?

julienrbrt · 2023-12-12T10:18:14Z

For keys add it makes sense for keys show not so sure. If people rely on this weird behavior they 0.51 won't work for them anymore.

What about showing warning message instead of return error(break the process)?

Yes, I think it's better for show to do it that way!

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

…in/cosmos-sdk into feat/check-duplicate-key

odeke-em

Nice work, and thank you @levisyin! Mostly LGTM, but just some suggestions like tightening up the tests.

odeke-em

LGTM, thank you @levisyin!

atheeshp

lgtm

julienrbrt

utACK!

aljo242 · 2025-03-26T21:48:32Z

@Mergiyio backport release/v0.53.x

aljo242 · 2025-03-26T21:56:37Z

@Mergifyio backport release/v0.53.x

mergify · 2025-03-26T21:56:49Z

backport release/v0.53.x

✅ Backports have been created

Details

#24153 feat(client/keys): check multisig key duplicate (backport #18703) has been created for branch release/v0.53.x but encountered conflicts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit f876b14) # Conflicts: # CHANGELOG.md # client/keys/show.go

…4153) Co-authored-by: levisyin <150114626+levisyin@users.noreply.github.com> Co-authored-by: aljo242 <alex@interchainlabs.io>

feat: check multisig key duplicate

2cea8f6

levisyin requested a review from a team December 12, 2023 05:48

add changelog

409b23e

julienrbrt suggested changes Dec 12, 2023

View reviewed changes

Merge branch 'main' into feat/check-duplicate-key

2f8b9ba

coderabbitai Bot reviewed Dec 12, 2023

View reviewed changes

Comment thread CHANGELOG.md Outdated

levisyin and others added 3 commits December 12, 2023 18:31

show warning message instead of return error

7942012

Update CHANGELOG.md

86efdae

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Merge branch 'feat/check-duplicate-key' of github-levisyin.com:levisy…

122654b

…in/cosmos-sdk into feat/check-duplicate-key

odeke-em suggested changes Dec 12, 2023

View reviewed changes

levisyin and others added 2 commits December 13, 2023 09:16

update for suggestion change

9000881

Merge branch 'main' into feat/check-duplicate-key

deabd59

coderabbitai Bot reviewed Dec 13, 2023

View reviewed changes

Comment thread client/keys/show_test.go

Comment thread client/keys/add.go

levisyin requested a review from odeke-em December 13, 2023 01:32

odeke-em approved these changes Dec 13, 2023

View reviewed changes

levisyin requested a review from julienrbrt December 13, 2023 02:14

atheeshp approved these changes Dec 13, 2023

View reviewed changes

likhita-809 approved these changes Dec 13, 2023

View reviewed changes

julienrbrt approved these changes Dec 13, 2023

View reviewed changes

julienrbrt added this pull request to the merge queue Dec 13, 2023

Merged via the queue into cosmos:main with commit f876b14 Dec 13, 2023

levisyin deleted the feat/check-duplicate-key branch December 13, 2023 08:30

This was referenced Feb 25, 2025

Keys issues eval #23790

Closed

[Epic]: Individual issue backports for v53 #23766

Closed

mergify Bot mentioned this pull request Mar 26, 2025

feat(client/keys): check multisig key duplicate (backport #18703) #24153

Merged

Conversation

levisyin commented Dec 12, 2023

Description

Uh oh!

coderabbitai Bot commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Uh oh!

julienrbrt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

levisyin commented Dec 12, 2023

Uh oh!

julienrbrt commented Dec 12, 2023

Uh oh!

Uh oh!

odeke-em left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

odeke-em left a comment

Choose a reason for hiding this comment

Uh oh!

atheeshp left a comment

Choose a reason for hiding this comment

Uh oh!

julienrbrt left a comment

Choose a reason for hiding this comment

Uh oh!

aljo242 commented Mar 26, 2025

Uh oh!

aljo242 commented Mar 26, 2025

Uh oh!

mergify Bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai Bot commented Dec 12, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)

julienrbrt left a comment •

edited

Loading

mergify Bot commented Mar 26, 2025 •

edited

Loading