feat(client): add WithFromName to tx factory#18852
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
| return f | ||
| } | ||
|
|
||
| // WithFromName returns a copy of the Factory with updated fromName |
There was a problem hiding this comment.
Can get this more descriptive and explain that it should most likely be clientCtx.FromName?
WithFromName to tx factory
|
Can we add a changelog under Improvements as well? |
| // WithFromName returns a copy of the Factory with updated fromName | ||
| // fromName will be use for building a simulation tx. |
There was a problem hiding this comment.
Consider enhancing the comment for the WithFromName method to explain its use case more clearly, such as indicating that it is used for building simulation transactions, potentially with the clientCtx.FromName as the source of the name.
(cherry picked from commit 64dbee6) # Conflicts: # CHANGELOG.md
(cherry picked from commit 64dbee6) # Conflicts: # CHANGELOG.md
cosmos#18854) Co-authored-by: gsai967 <153279976+gsai967@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#18854) Co-authored-by: gsai967 <153279976+gsai967@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
Closes: #XXXX
In recent 0.47.7 version tx.Factory added new feild
fromName, but it is only only set byNewFactoryCLIwe need to set
fromNameusingwithFromName()because we need use this to simulate the txn without usingNewFactoryCLIAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...