refactor(x/gov): set environment in context for legacy proposals#20521
Conversation
|
Warning Rate limit exceeded@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 52 minutes and 33 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe update introduces changes to the government module's handling of legacy proposals when transitioning to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- UPGRADING.md (1 hunks)
- x/gov/keeper/msg_server.go (2 hunks)
- x/gov/keeper/proposal.go (2 hunks)
Additional context used
Path-based instructions (3)
x/gov/keeper/proposal.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/gov/keeper/msg_server.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.UPGRADING.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
UPGRADING.md
[typographical] ~10-~10: It appears that a comma is missing.
Context: .... ## [Unreleased] ### SimApp In this section we describe the changes made in Cosmos ...
[typographical] ~10-~10: Unpaired symbol: ‘'’ seems to be missing
Context: ... describe the changes made in Cosmos SDK' SimApp. **These changes are directly ap...
[uncategorized] ~126-~126: Possible missing article found.
Context: ...sures the manager's state is written to file such that when the node restarts, it ...
[grammar] ~171-~171: The verb ‘depend’ can be stative. If ‘depending’ describes a state, change the sentence structure and use the base form of the verb.
Context: ...ild/docs/bsr/generated-sdks/go). If you were depending oncosmossdk.io/api/tendermint, pleas...
[grammar] ~181-~181: The verb ‘recommend’ is used with the gerund form.
Context: ...precation ofsdk.Context, we strongly recommend to use thecosmossdk.io/core/appmoduleinter...
[uncategorized] ~225-~225: Possible missing comma found.
Context: ... (sdk.Msg, error) ``` ##### Depinject Previouslycosmossdk.io/coreheld functions `Inv...
[style] ~231-~231: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ved. It is required to migrate to v0.50 prior to upgrading to v0.51 for not missing any ...
[grammar] ~252-~252: The singular determiner ‘this’ may not agree with the plural noun ‘changes’. Did you mean “these”?
Context: ...Many functions have been removed due to this changes as the API can be smaller thank...
[uncategorized] ~252-~252: Possible missing comma found.
Context: ...functions have been removed due to this changes as the API can be smaller thanks to col...
[uncategorized] ~264-~264: Possible missing article found.
Context: ...cosmossdk.io/x/authz####x/bankBank was spun out into its owngo.mod. To ...
[uncategorized] ~274-~274: Possible missing article found.
Context: ...x/protocolpool module. ####x/groupGroup was spun out into its owngo.mod. To ...
[uncategorized] ~300-~300: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ams` A standalone Go module was created and it is accessible at "cosmossdk.io/x/par...
[uncategorized] ~335-~335: Possible missing comma found.
Context: ...o CometBFT (Part 2) The Cosmos SDK has migrated in its previous versions, to CometBFT. ...
[typographical] ~368-~368: It appears that a comma is missing.
Context: ...genesis.json` file. For existing chains this can be done in two ways: * During an u...
[typographical] ~370-~370: Consider adding a comma after this introductory phrase.
Context: ...s can be done in two ways: * During an upgrade the value is set in an upgrade handler....
[uncategorized] ~377-~377: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...here a catastrophic failure has occurred and the application should halt. However, t...
[misspelling] ~379-~379: Did you maybe mean “buy” or “be”?
Context: ... that returns an error, will gracefully by handled byBaseAppon behalf of the a...
[style] ~384-~384: Consider a shorter alternative to avoid wordiness.
Context: ...lizeBlock` is public and should be used in order to test and run operations. This means tha...
[grammar] ~397-~397: Did you mean “modifying”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun.
Context: ...begin blocker other modules, and allows to modify consensus parameters, and the changes a...
[uncategorized] ~435-~435: A comma may be missing after the conjunctive/linking adverb ‘Instead’.
Context: ...he case of successful msg(s) execution. Instead a new attribute is added to all message...
[grammar] ~462-~462: The word “clean-up” is a noun. The verb is spelled with a white space.
Context: ...s well as its settings. Useconfixto clean-up yourapp.toml. A nginx (or alike) rev...
[misspelling] ~466-~466: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... not supported anymore. To migrate from a unsupported database to a supported dat...
[typographical] ~466-~466: Consider adding a comma here.
Context: ...pported database to a supported database please use a database migration tool. ### Pro...
[typographical] ~483-~483: It appears that a comma is missing.
Context: ...tate-machine code. ### SimApp In this section we describe the changes made in Cosmos ...
[typographical] ~483-~483: Unpaired symbol: ‘'’ seems to be missing
Context: ... describe the changes made in Cosmos SDK' SimApp. **These changes are directly ap...
[uncategorized] ~547-~547: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...on. The global variable has been removed and the basic module manager can be now cre...
[uncategorized] ~583-~583: A comma may be missing after the conjunctive/linking adverb ‘Additionally’.
Context: ... not to be included in the binary. ::: AdditionallyAutoCLIautomatically adds the custom...
[uncategorized] ~614-~614: Possible missing comma found.
Context: ... is extracted to have a separate go.mod file which allows it be a standalone module....
[grammar] ~614-~614: The preposition ‘to’ may be missing (allow someone to do something).
Context: ... a separate go.mod file which allows it be a standalone module. All the store impo...
[misspelling] ~635-~635: This word is normally spelled with a hyphen.
Context: ...available in the SDK that produces more human readable output, currently only available on Led...
[grammar] ~679-~679: Two determiners in a row. Choose either “the” or “a”.
Context: ...``` When usingdepinject/ `app v2`, the a tx config should be recreated from the ...
[grammar] ~704-~704: It looks like ‘interfaces’ doesn’t match ‘an’. Did you mean “an interface” or just “interfaces”?
Context: ...d ofsdk.Context. Any module that has an interfaces for them (like "expected keepers") will...
[uncategorized] ~755-~755: Possible missing comma found.
Context: ...ge. The signer field is required on all messages unless using a custom signer function. ...
[typographical] ~757-~757: Consider adding a comma here.
Context: ...ustom signer function. To find out more please read the [signer field](https://github....
[misspelling] ~770-~770: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...has migrated from a CometBFT genesis to a application managed genesis file. The g...
[misspelling] ~790-~790: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...ameter. An expedited proposal must have an higher voting threshold than a classic ...
[uncategorized] ~794-~794: It seems likely that a singular genitive (’s) apostrophe is missing.
Context: ...nt toProposalCancelDestaddress. The deposits burn rate will be determined by a new p...
[grammar] ~807-~807: The preposition ‘to’ may be missing (allow someone to do something).
Context: ... a separate go.mod file which allows it be a standalone module. All the evidence i...
[uncategorized] ~814-~814: Possible missing comma found.
Context: ... is extracted to have a separate go.mod file which allows it to be a standalone modu...
[grammar] ~835-~835: Did you mean the possessive pronoun “its”?
Context: ...ing #### Rosetta Rosetta has moved to it's own [repo](https://github.com/cosmos/ro...
[uncategorized] ~836-~836: After the verb ‘interested’ the preposition “in” is used.
Context: ... by default. Any user who is interested on using the tool can connect it standalon...
[misspelling] ~837-~837: This word is normally spelled as one.
Context: ...de binary. The rosetta tool also allows multi chain connections. ## [v0.47.x](https://gith...
[typographical] ~859-~859: The word “however” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...dom parameter changes during simulations, however, it does so through ParamChangeProposal ...
[grammar] ~861-~861: The noun should probably be in the singular form.
Context: ...teParamsgovernance proposals for each modules,AppModuleSimulationnow defines aA...
[style] ~876-~876: Consider using “formerly” to strengthen your wording.
Context: ... modules no longer support the REST API previously known as the LCD, and the `sdk.Msg#Rout...
[style] ~893-~893: Consider a shorter alternative to avoid wordiness.
Context: ...dd the following lines to yourapp.goin order to provide newer gRPC services: ```go aut...
[uncategorized] ~910-~910: Possible missing comma found.
Context: ...riod). These were unnecessary given as arguments as they were already present in theAp...
[uncategorized] ~914-~914: A comma may be missing after the conjunctive/linking adverb ‘Instead’.
Context: ...)was deprecated and has been removed. Instead you can use theTestEncodingConfig` fr...
[grammar] ~924-~924: The modal verb ‘must’ requires the verb’s base form.
Context: ... Replaces TheGoLevelDBversion must pinned to `v1.0.1-0.20210819022825-2ae1ddf74ef...
[grammar] ~935-~935: The word ‘replace’ is a verb. Did you mean the noun “replacement”?
Context: ...goproto. This allows you to remove the replace directivereplace github.com/gogo/prot...
[formatting] ~943-~943: You have used ‘I’ with an apostrophe, but either the verb is missing or you have not used the corresponding abbreviated form. Consider using one of the suggestions or removing the apostrophe.
Context: ...ly the rootproto/folder, set by theprotoc -Iflag). For example, assuming you put a...
[style] ~953-~953: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...ace` annotations. We require them to be fully-scoped names. They will soon be used by code g...
[style] ~971-~971: The word “also” tends to be overused. Consider using a formal alternative to strengthen your wording.
Context: ...os.feegrant.v1beta1.FeeAllowanceI" ``` Please also check that in your own app's proto file...
[style] ~972-~972: Try using a more formal synonym for ‘check’.
Context: ...v1beta1.FeeAllowanceI" ``` Please also check that in your own app's proto files that...
[style] ~972-~972: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...otations. If so, then replace them with fully-qualified names, even though those names don't ac...
[locale-violation] ~1012-~1012: In American English, “take a look” is more commonly used.
Context: ...e modules keepers in previous versions. Have a look atsimapp.RegisterUpgradeHandlers()f...
[misspelling] ~1030-~1030: Did you mean “At a Time”, “At the Time”, or “At times”?
Context: ...x/gov##### Minimum Proposal Deposit At Time of Submission Thegovmodule has bee...
[misspelling] ~1037-~1037: Did you mean “at a time”, “at the time”, or “at times”?
Context: ...o utilize the minimum proposal deposits at time of submission, the migration logic need...
[uncategorized] ~1042-~1042: Possible missing comma found.
Context: ...dated with proposer field. For proposal state migraton developers can call `v4.AddPro...
[uncategorized] ~1069-~1069: A comma is probably missing here.
Context: ...ng Tendermint consensus parameters. For migration it is required to call a specific migra...
[style] ~1096-~1096: Consider a shorter alternative to avoid wordiness.
Context: ...should still be imported in your app.go in order to handle this migration. Because the `x/...
[style] ~1158-~1158: Consider a shorter alternative to avoid wordiness.
Context: ...ally, new packages have been introduced in order to further split the codebase. Aliases are...
[uncategorized] ~1190-~1190: Possible missing comma found.
Context: ...ndex represents the latest state of the IAVL laid out in a format that preserves dat...
[uncategorized] ~1209-~1209: Possible missing article found.
Context: ...ur of each module housing and providing way to modify their parameters. Each module...
[typographical] ~1210-~1210: It appears that a comma is missing.
Context: ...aintained until April 18, 2023. At this point the module will reach end of life and b...
[style] ~1215-~1215: Consider a shorter alternative to avoid wordiness.
Context: ...the new implementation is calledv1. In order to submit a proposal with `submit-proposal...
[style] ~1222-~1222: ‘by accident’ might be wordy. Consider a shorter alternative.
Context: ...g delegations. Users that have unbonded by accident or wish to cancel a undelegation can no...
[misspelling] ~1222-~1222: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... unbonded by accident or wish to cancel a undelegation can now specify the amount...
[grammar] ~1226-~1226: The auxiliary verb ‘do’ requires the base form of the verb.
Context: ...v0.45.3/third_party/proto) now does not contains directly the [proto files](https://gith...
[style] ~1228-~1228: Consider a shorter alternative to avoid wordiness.
Context: ...build/cosmos/cosmos-sdk` as dependency, in order to avoid having to copy paste these files....
[grammar] ~1228-~1228: Did you mean “copy and paste”?
Context: ...dependency, in order to avoid having to copy paste these files. The protos can as well be...
[duplication] ~1246-~1246: Possible typo: you repeated a word
Context: ...a node they are required to set a codec in in the grpc.Dial. More information can be ...
Additional comments not posted (63)
x/gov/keeper/proposal.go (2)
13-13: Added import forcorecontextto support new context handling in legacy proposals.
117-119: Ensure correct context handling for legacy proposals.#!/bin/bash # Description: Verify that the new context handling does not affect other modules negatively. # Test: Search for usage of `EnvironmentContextKey` in other modules. Expect: No unexpected usages that could lead to conflicts. rg --type go $'EnvironmentContextKey'x/gov/keeper/msg_server.go (2)
10-10: Added import forcorecontextto support new context handling in legacy proposals.
214-216: Ensure correct context handling for legacy proposals.#!/bin/bash # Description: Verify that the new context handling does not affect other modules negatively. # Test: Search for usage of `EnvironmentContextKey` in other modules. Expect: No unexpected usages that could lead to conflicts. rg --type go $'EnvironmentContextKey'UPGRADING.md (59)
Line range hint
10-10: Consider adding a comma after "SDK" for clarity.
[typographical]
Line range hint
126-126: Consider adding a comma after "file" for clarity.
[typographical]
Line range hint
171-171: Consider rephrasing to "If you were depending oncosmossdk.io/api/tendermint, please use the buf generated go SDK instead, or ask CometBFT to host the generated proto v2 code."
[grammar]
Line range hint
181-181: Consider rephrasing to "we strongly recommend using thecosmossdk.io/core/appmoduleinterfaces."
[grammar]
Line range hint
231-231: Consider rephrasing to "It is required to migrate to v0.50 before upgrading to v0.51 to avoid missing any module migrations."
[style]
Line range hint
252-252: Consider rephrasing to "Many functions have been removed due to these changes, as the API can be smaller thanks to collections."
[grammar]
Line range hint
335-335: Consider adding a comma after "versions" for clarity.
[typographical]
Line range hint
368-368: Consider adding a comma after "chains" for clarity.
[typographical]
Line range hint
370-370: Consider adding a comma after "upgrade" for clarity.
[typographical]
Line range hint
377-377: Consider adding a comma after "occurred" for clarity.
[uncategorized]
Line range hint
379-379: Consider rephrasing to "will be gracefully handled byBaseAppon behalf of the application."
[misspelling]
Line range hint
384-384: Consider rephrasing to "is public and should be used to test and run operations."
[style]
Line range hint
397-397: Consider rephrasing to "allows modification of consensus parameters, and the changes are visible to the following state machine logics."
[grammar]
Line range hint
435-435: Consider adding a comma after "Instead" for clarity.
[uncategorized]
Line range hint
462-462: Consider rephrasing to "Useconfixto clean up yourapp.toml."
[grammar]
Line range hint
466-466: Consider rephrasing to "To migrate from an unsupported database to a supported database, please use a database migration tool."
[misspelling]
Line range hint
466-466: Consider adding a comma after "database" for clarity.
[typographical]
Line range hint
547-547: Consider adding a comma after "removed" for clarity.
[uncategorized]
Line range hint
583-583: Consider adding a comma after "Additionally" for clarity.
[uncategorized]
Line range hint
614-614: Consider rephrasing to "which allows it to be a standalone module."
[grammar]
Line range hint
679-679: Consider rephrasing to "When usingdepinject/app v2, a tx config should be recreated from thetxConfigOptsto useNewGRPCCoinMetadataQueryFninstead of depending on the bank keeper (that is used in the server)."
[grammar]
Line range hint
704-704: Consider rephrasing to "Any module that has interfaces for them (like 'expected keepers') will need to update and re-generate mocks if needed."
[grammar]
Line range hint
755-755: Consider adding a comma after "function" for clarity.
[typographical]
Line range hint
757-757: Consider rephrasing to "To find out more, please read the signer field documentation."
[typographical]
Line range hint
770-770: Consider rephrasing to "has migrated from a CometBFT genesis to an application managed genesis file."
[misspelling]
Line range hint
790-790: Consider rephrasing to "An expedited proposal must have a higher voting threshold than a classic proposal."
[misspelling]
Line range hint
794-794: Consider rephrasing to "The deposits' burn rate will be determined by a new parameter calledProposalCancelRatio."
[uncategorized]
Line range hint
807-807: Consider rephrasing to "which allows it to be a standalone module."
[grammar]
Line range hint
814-814: Consider adding a comma after "file" for clarity.
[uncategorized]
Line range hint
835-835: Consider rephrasing to "Rosetta has moved to its own repo."
[grammar]
Line range hint
836-836: Consider rephrasing to "Any user who is interested in using the tool can connect it standalone to any node without the need to add it as part of the node binary."
[uncategorized]
Line range hint
837-837: Consider rephrasing to "The Rosetta tool also allows multi-chain connections."
[misspelling]
Line range hint
859-859: Consider rephrasing to "RemoveRandomizedParamsfromAppModuleSimulationinterface. Previously, it used to generate random parameter changes during simulations; however, it does so through ParamChangeProposal which is now legacy."
[typographical]
Line range hint
861-861: Consider rephrasing to "The noun should probably be in the singular form."
[grammar]
Line range hint
876-876: Consider rephrasing to "Previously, all modules were required to be set inOrderBeginBlockers,OrderEndBlockersandOrderInitGenesis / OrderExportGenesisinapp.go/app_config.go. This is no longer the case; the assertion has been loosened to only require modules implementing, respectively, theappmodule.HasBeginBlocker,appmodule.HasEndBlockerandappmodule.HasGenesis/module.HasGenesisinterfaces."
[style]
Line range hint
893-893: Consider rephrasing to "add the following lines to yourapp.goto provide newer gRPC services:"
[style]
Line range hint
910-910: Consider adding a comma after "arguments" for clarity.
[uncategorized]
Line range hint
914-914: Consider adding a comma after "Instead" for clarity.
[uncategorized]
Line range hint
924-924: Consider rephrasing to "TheGoLevelDBversion must be pinned tov1.0.1-0.20210819022825-2ae1ddf74ef7in the application, following versions might cause unexpected behavior."
[grammar]
Line range hint
935-935: Consider rephrasing to "This allows you to remove the replacement directivereplace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1from yourgo.modfile."
[grammar]
Line range hint
943-943: Consider rephrasing to "For example, assuming you put all your proto files in subfolders inside your rootproto/folder, then a proto file with package namemyapp.mymodule.v1should be found in theproto/myapp/mymodule/v1/folder."
[formatting]
Line range hint
953-953: Consider rephrasing to "We require them to be fully scoped names."
[style]
Line range hint
971-971: Consider rephrasing to "Please check that in your own app's proto files there are no single-word names for those two proto annotations."
[style]
Line range hint
972-972: Consider rephrasing to "If so, then replace them with fully qualified names, even though those names don't actually resolve to an actual protobuf entity."
[style]
Line range hint
1012-1012: Consider rephrasing to "Take a look atsimapp.RegisterUpgradeHandlers()for an example."
[locale-violation]
Line range hint
1030-1030: Consider rephrasing to "Minimum Proposal Deposit At the Time of Submission."
[misspelling]
Line range hint
1037-1037: Consider rephrasing to "If chains wish to utilize the minimum proposal deposits at the time of submission, the migration logic needs to be modified to set the new parameter to the desired value."
[misspelling]
Line range hint
1042-1042: Consider adding a comma after "migration" for clarity.
[uncategorized]
Line range hint
1069-1069: Consider adding a comma after "migration" for clarity.
[uncategorized]
Line range hint
1096-1096: Consider rephrasing to "Because thex/consensusmodule is a new module, its store must be added while upgrading to v0.47.x:"
[style]
Line range hint
1158-1158: Consider rephrasing to "Additionally, new packages have been introduced to further split the codebase."
[style]
Line range hint
1190-1190: Consider adding a comma after "state" for clarity.
[uncategorized]
Line range hint
1209-1209: Consider rephrasing to "Each module that has parameters that are changeable during runtime has an authority, which can be a module or user account."
[uncategorized]
Line range hint
1210-1210: Consider adding a comma after "2023" for clarity.
[typographical]
Line range hint
1215-1215: Consider rephrasing to "To submit a proposal withsubmit-proposal, you now need to pass aproposal.jsonfile."
[style]
Line range hint
1222-1222: Consider rephrasing to "Users that have unbonded accidentally or wish to cancel an undelegation can now specify the amount and validator they would like to cancel the unbond from."
[style]
Line range hint
1222-1222: Consider rephrasing to "Users that have unbonded accidentally or wish to cancel an undelegation can now specify the amount and validator they would like to cancel the unbond from."
[misspelling]
Line range hint
1226-1226: Consider rephrasing to "Thethird_party/protofolder that existed in previous versions now does not contain the proto files directly."
[grammar]
Line range hint
1228-1228: Consider rephrasing to "Instead, the SDK usesbuf. Clients should have their ownbuf.yamlwithbuf.build/cosmos/cosmos-sdkas a dependency, to avoid having to copy and paste these files."
[grammar]
* main: docs: add docs on permissions (#20526) refactor(x/gov): set environment in context for legacy proposals (#20521) docs: migrate diagrams to mermaidjs (#20503) refactor(tools/hubl): don't use nil panic (#20515) refactor(x/authz): set environment in context (#20502) build(deps): Bump github.com/spf13/viper from 1.18.2 to 1.19.0 (#20519) feat(x/bank): Placing SendRestriction before Deduction of Coins in SendCoins (#20517) chore: sonar ignore directories with their own go.mods (#20509) ci: run action in merge queue (#20508)
* main: refactor(x/feegrant): set environment in context (#20529) refactor(x/accounts)!: accounts and auth module use the same account number tracking (#20405) chore: remove sonar from simapp (#20528) docs: add docs on permissions (#20526) refactor(x/gov): set environment in context for legacy proposals (#20521) docs: migrate diagrams to mermaidjs (#20503) refactor(tools/hubl): don't use nil panic (#20515) refactor(x/authz): set environment in context (#20502) build(deps): Bump github.com/spf13/viper from 1.18.2 to 1.19.0 (#20519) feat(x/bank): Placing SendRestriction before Deduction of Coins in SendCoins (#20517) chore: sonar ignore directories with their own go.mods (#20509) ci: run action in merge queue (#20508) refactor(server/v2/cometbft): update function comments (#20506)
4 participants
Description
ref: #19640
The support of legacy gov proposal in server/v2 is different than for baseapp.
Legacy proposal in server/v2 can only access services provided by the gov module environment, which is a subset that what was available in the
sdk.Context.Should be fine, but users should be aware of this when upgrading to server/v2
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Documentation
Bug Fixes