fix(runtime): remove appv1alpha1.Config from runtime (backport #21042)#21079
Conversation
(cherry picked from commit 502450c)
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
@mergify[bot] your pull request is missing a changelog! |
Description
Since depinject v1, we actually do not supply
appv1alpha.Configwhen we useComposefrom a json: https://github.com/cosmos/cosmos-sdk/pull/20931/files#diff-27f72d7ebe452671125abb151c9e77c6b092536cfafcc734c4f10faade8d0d0dR23-R62.That poses an issue as runtime requires it: https://github.com/cosmosregistry/chain-minimal/actions/runs/10064766032/job/27822404477 / julienrbrt/chain-minimal#152
AppConfigactually does not need to be on runtime (as the app config service is gone), we should not require it to be available.This should be backported to v0.52 once #21041 is merged.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.mdupdated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
This is an automatic backport of pull request #21042 done by [Mergify](https://mergify.com).