Skip to content

fix(x/tx): fix amino json drift from legacy spec #21825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 20 commits into from
Oct 3, 2024
Merged

fix(x/tx): fix amino json drift from legacy spec #21825

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2985fb3
reworking aminojson tests
kocubinski Sep 17, 2024
5fc26b9
wip
kocubinski Sep 18, 2024
f7a559f
TestAminoJSON_LegacyParity now passing again
kocubinski Sep 18, 2024
8988b88
more fixes
kocubinski Sep 19, 2024
651b8ed
all green, cleaning up
kocubinski Sep 19, 2024
9e56d38
rm
kocubinski Sep 19, 2024
e5ac23d
rm more
kocubinski Sep 19, 2024
4e0d866
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocu/amino-j…
kocubinski Sep 19, 2024
cd607a9
Merge branch 'main' into kocu/amino-json-tests
kocubinski Sep 19, 2024
2336db4
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocu/amino-j…
kocubinski Sep 20, 2024
6cfe75f
Merge branch 'kocu/amino-json-tests' of github.com:cosmos/cosmos-sdk …
kocubinski Sep 20, 2024
62f47d8
fix test spec
kocubinski Sep 20, 2024
3e417a9
rm TODO
kocubinski Sep 20, 2024
14e7036
Merge branch 'main' into kocu/amino-json-tests
kocubinski Sep 23, 2024
0cc6478
CHANGELOG
kocubinski Sep 24, 2024
eb43522
Merge branch 'kocu/amino-json-tests' of github.com:cosmos/cosmos-sdk …
kocubinski Sep 24, 2024
a8ce3b5
Merge branch 'main' into kocu/amino-json-tests
kocubinski Sep 25, 2024
3e6a855
Merge branch 'main' into kocu/amino-json-tests
kocubinski Sep 30, 2024
9b5e432
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocu/amino-j…
kocubinski Oct 1, 2024
717e1b1
Merge branch 'main' into kocu/amino-json-tests
kocubinski Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/integration/rapidgen/rapidgen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ var (
NonsignableTypes = []GeneratedType{
GenType(&authtypes.Params{}, &authapi.Params{}, GenOpts),
GenType(&authtypes.BaseAccount{}, &authapi.BaseAccount{}, GenOpts.WithAnyTypes(&ed25519.PubKey{})),
GenType(&authtypes.ModuleAccount{}, &authapi.ModuleAccount{}, GenOpts.WithAnyTypes(&ed25519.PubKey{})),
GenType(&authtypes.ModuleCredential{}, &authapi.ModuleCredential{}, GenOpts),

GenType(&authztypes.GenericAuthorization{}, &authzapi.GenericAuthorization{}, GenOpts),
Expand Down Expand Up @@ -260,7 +259,9 @@ var (

GenType(&slashingtypes.Params{}, &slashingapi.Params{}, GenOpts.WithDisallowNil()),

GenType(&stakingtypes.StakeAuthorization{}, &stakingapi.StakeAuthorization{}, GenOpts),
// JSON ordering of one of fields to be fixed in https://github.com/cosmos/cosmos-sdk/pull/21782
// TODO uncomment once merged
// GenType(&stakingtypes.StakeAuthorization{}, &stakingapi.StakeAuthorization{}, GenOpts),

GenType(&upgradetypes.CancelSoftwareUpgradeProposal{}, &upgradeapi.CancelSoftwareUpgradeProposal{}, GenOpts), //nolint:staticcheck // testing legacy code path
GenType(&upgradetypes.SoftwareUpgradeProposal{}, &upgradeapi.SoftwareUpgradeProposal{}, GenOpts.WithDisallowNil()), //nolint:staticcheck // testing legacy code path
Expand Down
Loading