feat(systemtests): increase verbosity

[julienrbrt]

Description

Increase verbosity of system tests when --verbose is enabled.
Will help when debugging (cc @testinginprod)

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features
  • Enhanced CLI command execution with improved debug logging for better error visibility.
  • Added transaction hash existence check to improve transaction confirmation reliability.
  • Automatically appends default fees to command arguments for streamlined transaction processing.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the CLIWrapper struct in the tests/systemtests/cli.go file. Key updates include enhanced debug logging in the runWithInput method, a check for transaction hash existence in the AwaitTxCommitted method, and the addition of default fees in the Run method. These changes aim to improve error visibility, transaction confirmation robustness, and streamline command execution.

Changes

File	Change Summary
tests/systemtests/cli.go	- Updated runWithInput to include additional debug logging for output and errors.
	- Modified AwaitTxCommitted to check for transaction hash existence before waiting for confirmation.
	- Enhanced Run to append default fees to command arguments if not specified.

Possibly related PRs

• test: e2e/staking to system tests #21882: This PR updates the staking system tests to include checks for validator updates, which may relate to the transaction confirmation logic enhanced in the main PR.
• test: migrate e2e/mint to system tests #22294: This PR migrates end-to-end tests for minting functionality to system tests, which may involve similar transaction handling and CLI interactions as seen in the main PR's updates to the CLIWrapper methods.

Suggested labels

Type: CI, backport/v0.52.x

Suggested reviewers

• tac0turtle
• testinginprod

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

tests/systemtests/cli.go (1)

244-251: LGTM! Enhanced debug logging improves visibility.

The added debug logging for both error and standard output enhances the visibility of command execution results, which is beneficial for debugging system tests. This change aligns well with the PR objective of increasing verbosity when the --verbose flag is enabled.

Consider using a structured logging library like logrus or zap for more consistent and easily parseable log output. This could further improve debugging capabilities in the future.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 29ea9c8 and cc23c2a.

📒 Files selected for processing (1)

• tests/systemtests/cli.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

tests/systemtests/cli.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"