chore: prep release#23349
Conversation
📝 WalkthroughWalkthroughThis pull request involves multiple updates across various modules in the Cosmos SDK. The primary changes include updating the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
Bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
ghost
assigned
Co-authored-by: Marko <marko@baricevic.me>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
x/bank/go.mod (1)
Line range hint
186-187: Track TODO comment for future module separation.The TODO comment indicates pending work to remove the replace directives after spinning out all modules.
Would you like me to create a GitHub issue to track this TODO item?
x/protocolpool/go.mod (1)
Line range hint
186-190: Track TODO comment for future module separation.The TODO comment indicates pending work to remove the replace directives after spinning out all modules.
Would you like me to create a GitHub issue to track this TODO item?
client/v2/autocli/testdata/msg-output.golden (1)
1-1: LGTM - Consistent handling of unset timeoutThe change maintains consistency with the previous file, standardizing the representation of unset timeouts as
nullinstead of Unix epoch. This is a more semantically correct approach.Consider updating the API documentation to explicitly mention that
timeout_timestampis nullable and what null values mean in this context.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (26)
client/v2/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumserver/v2/cometbft/go.sumis excluded by!**/*.sumsimapp/v2/go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sumtools/benchmark/go.sumis excluded by!**/*.sumx/accounts/defaults/base/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.sumis excluded by!**/*.sumx/accounts/defaults/multisig/go.sumis excluded by!**/*.sumx/accounts/go.sumis excluded by!**/*.sumx/authz/go.sumis excluded by!**/*.sumx/bank/go.sumis excluded by!**/*.sumx/circuit/go.sumis excluded by!**/*.sumx/consensus/go.sumis excluded by!**/*.sumx/distribution/go.sumis excluded by!**/*.sumx/epochs/go.sumis excluded by!**/*.sumx/evidence/go.sumis excluded by!**/*.sumx/feegrant/go.sumis excluded by!**/*.sumx/gov/go.sumis excluded by!**/*.sumx/group/go.sumis excluded by!**/*.sumx/mint/go.sumis excluded by!**/*.sumx/nft/go.sumis excluded by!**/*.sumx/protocolpool/go.sumis excluded by!**/*.sumx/slashing/go.sumis excluded by!**/*.sumx/staking/go.sumis excluded by!**/*.sumx/upgrade/go.sumis excluded by!**/*.sum
📒 Files selected for processing (30)
client/v2/autocli/testdata/flatten-output.golden(1 hunks)client/v2/autocli/testdata/msg-output.golden(1 hunks)client/v2/go.mod(1 hunks)go.mod(1 hunks)scripts/build/protobuf.mk(1 hunks)server/v2/cometbft/go.mod(1 hunks)simapp/v2/go.mod(1 hunks)store/v2/CHANGELOG.md(1 hunks)tests/go.mod(1 hunks)tools/benchmark/go.mod(1 hunks)x/accounts/defaults/base/go.mod(1 hunks)x/accounts/defaults/lockup/go.mod(1 hunks)x/accounts/defaults/multisig/go.mod(1 hunks)x/accounts/go.mod(1 hunks)x/authz/go.mod(1 hunks)x/bank/go.mod(1 hunks)x/circuit/go.mod(1 hunks)x/consensus/go.mod(1 hunks)x/distribution/go.mod(1 hunks)x/epochs/go.mod(1 hunks)x/evidence/go.mod(1 hunks)x/feegrant/go.mod(1 hunks)x/gov/go.mod(1 hunks)x/group/go.mod(1 hunks)x/mint/go.mod(1 hunks)x/nft/go.mod(1 hunks)x/protocolpool/go.mod(1 hunks)x/slashing/go.mod(1 hunks)x/staking/go.mod(1 hunks)x/upgrade/go.mod(1 hunks)
✅ Files skipped from review due to trivial changes (14)
- x/evidence/go.mod
- x/mint/go.mod
- scripts/build/protobuf.mk
- x/upgrade/go.mod
- x/nft/go.mod
- x/authz/go.mod
- x/staking/go.mod
- x/accounts/defaults/base/go.mod
- x/accounts/defaults/lockup/go.mod
- x/feegrant/go.mod
- x/epochs/go.mod
- client/v2/go.mod
- x/gov/go.mod
- x/distribution/go.mod
🧰 Additional context used
📓 Path-based instructions (2)
store/v2/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
tests/go.mod (1)
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (15)
store/v2/CHANGELOG.md (1)
28-32: LGTM! Changelog follows standard format and properly documents breaking changes.The changelog entry for v2.0.0-beta.2 is well-structured and includes proper references to the relevant pull requests.
tools/benchmark/go.mod (1)
6-6: LGTM! API version update is consistent with other modules.The update of
cosmossdk.io/apito v0.8.1 aligns with the PR objectives and maintains consistency across modules.x/consensus/go.mod (1)
6-6: LGTM! API version update is consistent with other modules.The update of
cosmossdk.io/apito v0.8.1 aligns with the PR objectives and maintains consistency across modules.x/bank/go.mod (1)
6-6: LGTM! API version update is consistent with other modules.The update of
cosmossdk.io/apito v0.8.1 aligns with the PR objectives and maintains consistency across modules.x/protocolpool/go.mod (1)
6-6: LGTM! API version update is consistent with other modules.The update of
cosmossdk.io/apito v0.8.1 aligns with the PR objectives and maintains consistency across modules.x/slashing/go.mod (1)
6-6: LGTM: API version update is consistent.The update of
cosmossdk.io/apito v0.8.1 aligns with the coordinated version bump across modules.x/circuit/go.mod (1)
6-6: LGTM: API version update is consistent.The update of
cosmossdk.io/apito v0.8.1 aligns with the coordinated version bump across modules.x/accounts/defaults/multisig/go.mod (1)
21-21: LGTM: API version update is consistent.The update of the indirect dependency
cosmossdk.io/apito v0.8.1 aligns with the coordinated version bump across modules.x/accounts/go.mod (1)
6-6: LGTM: API version update is consistent.The update of
cosmossdk.io/apito v0.8.1 aligns with the coordinated version bump across modules.x/group/go.mod (1)
6-6: LGTM: API version update is consistent.The update of
cosmossdk.io/apito v0.8.1 aligns with the coordinated version bump across modules.go.mod (1)
6-6: LGTM! Version update is consistent.The update of
cosmossdk.io/apito v0.8.1 aligns with the PR objectives.server/v2/cometbft/go.mod (1)
17-17: LGTM! Version is consistent with main module.The update of
cosmossdk.io/apito v0.8.1 matches the version in the main go.mod file.tests/go.mod (1)
6-6: LGTM! Version is consistent with main module.The update of
cosmossdk.io/apito v0.8.1 matches the version in the main go.mod file.simapp/v2/go.mod (1)
6-6: LGTM! Version is consistent with main module.The update of
cosmossdk.io/apito v0.8.1 matches the version in the main go.mod file.client/v2/autocli/testdata/flatten-output.golden (1)
1-1: Verify alignment with API changesThe change from Unix epoch timestamp to
nullfortimeout_timestampappears to be a more accurate representation of an unset timeout. However, we should verify this change aligns with the API update mentioned in the PR objectives.Let's check for related changes in the API:
✅ Verification successful
Change from Unix epoch to null is correct
The change aligns with the protocol definition where
timeout_timestampis explicitly marked as nullable. Since this transaction hasunordered=false, a null timeout is valid as timeouts are only mandatory for unordered transactions.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for timeout_timestamp related changes in proto files and API definitions rg -g '*.proto' -g '*.go' 'timeout_timestamp'Length of output: 5073
|
@Mergifyio backport release/v0.52.x |
✅ Backports have been createdDetails
|
Co-authored-by: Marko <marko@baricevic.me> (cherry picked from commit 3586e39) # Conflicts: # client/v2/go.mod # client/v2/go.sum # go.mod # server/v2/cometbft/go.mod # server/v2/cometbft/go.sum # simapp/v2/go.mod # simapp/v2/go.sum # tests/go.mod # tools/benchmark/go.mod # tools/benchmark/go.sum # x/accounts/defaults/base/go.mod # x/accounts/defaults/base/go.sum # x/accounts/defaults/lockup/go.mod # x/accounts/defaults/lockup/go.sum # x/accounts/defaults/multisig/go.mod # x/accounts/defaults/multisig/go.sum # x/accounts/go.mod # x/accounts/go.sum # x/authz/go.mod # x/authz/go.sum # x/bank/go.mod # x/bank/go.sum # x/circuit/go.mod # x/circuit/go.sum # x/consensus/go.mod # x/consensus/go.sum # x/distribution/go.mod # x/distribution/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/evidence/go.mod # x/evidence/go.sum # x/feegrant/go.mod # x/feegrant/go.sum # x/gov/go.mod # x/gov/go.sum # x/group/go.mod # x/group/go.sum # x/mint/go.mod # x/mint/go.sum # x/nft/go.mod # x/nft/go.sum # x/params/CHANGELOG.md # x/protocolpool/go.mod # x/protocolpool/go.sum # x/slashing/go.mod # x/slashing/go.sum # x/staking/go.mod # x/staking/go.sum # x/upgrade/go.mod # x/upgrade/go.sum
3 participants
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Dependency Updates
cosmossdk.io/apidependency from v0.8.0 to v0.8.1 across multiple modulescosmossdk.io/apiin some modulesChangelog
store/v2(v2.0.0-beta.2)Test Data
timeout_timestampfield tonullin some test data files