refactor(x/bank): swap sendrestriction check in InputOutputCoins (backport #21976)#24053
Merged
technicallyty merged 9 commits intoMar 25, 2025
Merged
Conversation
) (cherry picked from commit bb7d11d) # Conflicts: # x/bank/CHANGELOG.md # x/bank/keeper/send.go # x/group/keeper/abci.go
Contributor
Author
|
Cherry-pick of bb7d11d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
i can pick this up and get it through the finish line if thats cool with you @julienrbrt |
Contributor
Sure! Forgot about this one. |
Member
|
updated the PR. please have a look! |
aljo242
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #23833
This PR switches the
subUnlockedCoinsand send restrictions checks inInputOutputCoins.Users should always use a cache context anyway, but this resolves a footgun if someone forgets to.
I thought we already swapped those, as it was suggested once by Injective (cc @kakysha), and it came up again in a report.
As it is still a behavior change, we'll only backport this to 0.52. The current behavior shouldn't pose any issue to 0.50.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.mdupdated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
MsgBurnfor burning coins.SendRestrictionFn.Improvements
Bug Fixes
SpendableBalancesandSpendableCoinsqueries for accurate balance reporting.API Breaking Changes
BurnCoinsand various balance query requests.Tests
This is an automatic backport of pull request #21976 done by [Mergify](https://mergify.com).