Skip to content

test (sims): Remove baseapp from sims signature in x/modules#24062

Closed
alpe wants to merge 3 commits into
alex/23762_simsxfrom
alex/23762_simsx_2
Closed

test (sims): Remove baseapp from sims signature in x/modules#24062
alpe wants to merge 3 commits into
alex/23762_simsxfrom
alex/23762_simsx_2

Conversation

@alpe
Copy link
Copy Markdown
Contributor

@alpe alpe commented Mar 19, 2025

🚧 After #24045

Remove baseapp from sims signature in x/modules

See #23762

Includes

826d4d3f28 - refactor(sims)!: Remove Baseapp from sims (backport #21039) (#21058)
b0652195d8 - test(x/slashing): fix slashing sims (#20995)
dc5c16b0be - fix (sims): state written in sims loop (#20936)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

alpe and others added 3 commits March 19, 2025 15:25
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
(cherry picked from commit 826d4d3)
Comment thread types/simulation/types.go
// Operations can optionally provide a list of "FutureOperations" to run later
// These will be ran at the beginning of the corresponding block.
type Operation func(r *rand.Rand, app *baseapp.BaseApp,
type Operation func(r *rand.Rand, app AppEntrypoint,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that would affect module developers. The main motivation was to remove the dependency to baseapp for the x/modules.
I will 🤔 about some alternatives

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we don't need to do this. I think we can just keep the baseapp dependency

Comment thread simapp/go.mod
cosmossdk.io/api => ../api
cosmossdk.io/log => ../log
cosmossdk.io/x/feegrant => ../x/feegrant/.
cosmossdk.io/x/nft => ../x/nft/.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some x/modules come with their own go.mod. Until they are removed or there is a new release, these replace statements ensure that the latest version of this branch is used

@alpe
Copy link
Copy Markdown
Contributor Author

alpe commented Mar 19, 2025

I will do another try with less changes if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants