test (sims): Remove baseapp from sims signature in x/modules#24062
Closed
alpe wants to merge 3 commits into
Closed
test (sims): Remove baseapp from sims signature in x/modules#24062alpe wants to merge 3 commits into
alpe wants to merge 3 commits into
Conversation
(cherry picked from commit b065219)
alpe
commented
Mar 19, 2025
| // Operations can optionally provide a list of "FutureOperations" to run later | ||
| // These will be ran at the beginning of the corresponding block. | ||
| type Operation func(r *rand.Rand, app *baseapp.BaseApp, | ||
| type Operation func(r *rand.Rand, app AppEntrypoint, |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change that would affect module developers. The main motivation was to remove the dependency to baseapp for the x/modules.
I will 🤔 about some alternatives
Contributor
There was a problem hiding this comment.
For now, we don't need to do this. I think we can just keep the baseapp dependency
alpe
commented
Mar 19, 2025
| cosmossdk.io/api => ../api | ||
| cosmossdk.io/log => ../log | ||
| cosmossdk.io/x/feegrant => ../x/feegrant/. | ||
| cosmossdk.io/x/nft => ../x/nft/. |
Contributor
Author
There was a problem hiding this comment.
Some x/modules come with their own go.mod. Until they are removed or there is a new release, these replace statements ensure that the latest version of this branch is used
Contributor
Author
|
I will do another try with less changes if possible |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 After #24045
Remove baseapp from sims signature in x/modules
See #23762
Includes
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...