refactor(client): check name validation for keys add|import|rename (backport #18950)#24152
Merged
Merged
Conversation
Contributor
Author
|
Cherry-pick of c307001 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
aljo242
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When I set the $name variable by mistake, and after running
keys add $namecommand, it created a key with the empty name.This looks odd when I ran

keys listto check the created key, see the screenshot below. I'm confused about the name, is it empty or just the""itself.Also, an unnormal name isn't friendly to
keys delete,keys show, andkeys exportsubcommand.So I think we should prevent from creating a key with an unnormal name
This is an automatic backport of pull request #18950 done by [Mergify](https://mergify.com).