add MutableTree.SetInitialVersion()#312
Merged
Merged
Conversation
amaury1093
approved these changes
Aug 26, 2020
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
lgtm, I believe this will unblock my PR on the cosmos-sdk 👍
Contributor
Author
|
I'll need an approval from a grown-up, I'm afraid - the repo is set up like that. @alexanderbez, want to do the honors? |
alexanderbez
approved these changes
Aug 26, 2020
RavenXce
pushed a commit
to Switcheo/iavl
that referenced
this pull request
Aug 28, 2020
Requested in cosmos/cosmos-sdk#7089 (comment). I didn't add a `GetInitialVersion()`, since it's not clear whether this should return only the option or the _actual_ initial version that exists in a tree. It might be cleaner to add `GetOptions()`, `SetOptions()`, and `UpdateOptions(func (o Options) Options)`, but we may not want all options to be mutable after construction. CC @amaurymartiny
erikgrinaker
added a commit
that referenced
this pull request
Sep 25, 2020
Requested in cosmos/cosmos-sdk#7089 (comment). I didn't add a `GetInitialVersion()`, since it's not clear whether this should return only the option or the _actual_ initial version that exists in a tree. It might be cleaner to add `GetOptions()`, `SetOptions()`, and `UpdateOptions(func (o Options) Options)`, but we may not want all options to be mutable after construction. CC @amaurymartiny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in cosmos/cosmos-sdk#7089 (comment).
I didn't add a
GetInitialVersion(), since it's not clear whether this should return only the option or the actual initial version that exists in a tree.It might be cleaner to add
GetOptions(),SetOptions(), andUpdateOptions(func (o Options) Options), but we may not want all options to be mutable after construction.CC @amaurymartiny