feat: Add skipFastStorageUpgrade to MutableTree to control fast storage upgrade#547
Merged
Merged
Conversation
ea25c74 to
7cb9973
Compare
skipFastStorageUpgrade to MutableTree to control fast storage upgradeskipFastStorageUpgrade to MutableTree to control fast storage upgrade
tac0turtle
approved these changes
Sep 13, 2022
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
LGTM, we will have to push this to a branch without the cosmos-db changes.
Contributor
Author
is this not compatible with |
Contributor
|
I can handle this part, will start right when this is merged. Would like to get one more review before then |
alexanderbez
approved these changes
Sep 14, 2022
faddat
added a commit
to faddat/iavl
that referenced
this pull request
Nov 25, 2022
…l fast storage upgrade (cosmos#547)" This reverts commit fcab556.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
skipFastStorageUpgradefield toMutalbeTree.If
skipFastStorageUpgradeis true, neitherLoad(),LazyLoadVersion(),LoadVersion()norLoadVersionForOverwritingwould try to upgrade fast storage when loading the tree.This is needed for archive nodes with extremely big db to avoid taking unacceptable long time to upgrade the fast storage