io_buffer_param is in Boost.Corosio#249
Conversation
📝 WalkthroughWalkthroughThis pull request adds corosio as a build dependency and replaces the internal buffering mechanism in the route handler from capy::buffer_param to corosio::io_buffer_param, including updates to virtual function signatures and test implementations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CMakeLists.txt (1)
55-69: Add corosio to the standalone CMake find_package components.Line 61 includes
Boost::corosioinBOOST_HTTP_DEPENDENCIES, and the codebase actively usescorosio::io_buffer_paramfrom<boost/corosio/io_buffer_param.hpp>. However, Line 125'sfind_package(Boost REQUIRED COMPONENTS filesystem json url)omitscorosio. In standalone builds (non-superproject), the missing target will be aliased toBoost::headersinstead of the actual Boost.Corosio library, causing build or runtime failures.🔧 Suggested CMake fix
- find_package(Boost REQUIRED COMPONENTS filesystem json url) + find_package(Boost REQUIRED COMPONENTS filesystem json url corosio)
Summary by CodeRabbit
Chores
Refactor
Tests
✏️ Tip: You can customize this high-level summary in your review settings.